From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, jasvinder.singh@intel.com,
cristian.dumitrescu@intel.com, jerin.jacob@caviumnetworks.com
Subject: [dpdk-dev] [PATCH 4/6] memalloc: use library implementation of 64-bit log2
Date: Tue, 11 Dec 2018 17:57:12 +0000 [thread overview]
Message-ID: <82204e76ebc56b7956d0388777aab03fbc4e343a.1544550999.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <1cf22c82b6ca7561966be674afb8a02add0913b9.1544550999.git.anatoly.burakov@intel.com>
In-Reply-To: <1cf22c82b6ca7561966be674afb8a02add0913b9.1544550999.git.anatoly.burakov@intel.com>
Remove duplicated code and use library version of 64-bit log2.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
lib/librte_eal/linuxapp/eal/eal_memalloc.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
index 784939566..6e6af5b06 100644
--- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
@@ -208,28 +208,13 @@ get_file_size(int fd)
return st.st_size;
}
-static inline uint32_t
-bsf64(uint64_t v)
-{
- return (uint32_t)__builtin_ctzll(v);
-}
-
-static inline uint32_t
-log2_u64(uint64_t v)
-{
- if (v == 0)
- return 0;
- v = rte_align64pow2(v);
- return bsf64(v);
-}
-
static int
pagesz_flags(uint64_t page_sz)
{
/* as per mmap() manpage, all page sizes are log2 of page size
* shifted by MAP_HUGE_SHIFT
*/
- int log2 = log2_u64(page_sz);
+ int log2 = rte_log2_u64(page_sz);
return log2 << RTE_MAP_HUGE_SHIFT;
}
--
2.17.1
next prev parent reply other threads:[~2018-12-11 17:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 17:57 [dpdk-dev] [PATCH 1/6] bitmap: remove deprecated bsf64 function Anatoly Burakov
2018-12-11 17:57 ` [dpdk-dev] [PATCH 2/6] common: add bsf64 function similar to existing bsf32 Anatoly Burakov
2018-12-20 9:08 ` Thomas Monjalon
2018-12-11 17:57 ` [dpdk-dev] [PATCH 3/6] common: add missing implementations Anatoly Burakov
2018-12-20 9:09 ` Thomas Monjalon
2018-12-20 9:16 ` Burakov, Anatoly
2018-12-11 17:57 ` Anatoly Burakov [this message]
2018-12-11 17:57 ` [dpdk-dev] [PATCH 5/6] testpmd: use library implementation of 64-bit log2 Anatoly Burakov
2018-12-12 11:22 ` Iremonger, Bernard
2018-12-11 17:57 ` [dpdk-dev] [PATCH 6/6] test/common: extend autotest to newly added functions Anatoly Burakov
2018-12-20 12:07 ` [dpdk-dev] [PATCH v2] common: add 64-bit log2 function Anatoly Burakov
2018-12-20 12:10 ` Burakov, Anatoly
2018-12-20 12:09 ` [dpdk-dev] [PATCH v2 1/4] bitmap: remove deprecated bsf64 function Anatoly Burakov
2018-12-20 23:44 ` Thomas Monjalon
2018-12-20 12:09 ` [dpdk-dev] [PATCH v2 2/4] common: add bsf64 and bsf32_safe functions Anatoly Burakov
2018-12-20 12:09 ` [dpdk-dev] [PATCH v2 3/4] common: add 64-bit fls function Anatoly Burakov
2018-12-20 12:09 ` [dpdk-dev] [PATCH v2 4/4] common: add 64-bit log2 function Anatoly Burakov
2018-12-20 22:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82204e76ebc56b7956d0388777aab03fbc4e343a.1544550999.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).