From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Zoltan Kiss <zoltan.kiss@schaman.hu>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Helin" <helin.zhang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>
Cc: Matias Elo <matias.elo@nokia-bell-labs.com>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"damarion@cisco.com" <damarion@cisco.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols
Date: Wed, 14 Sep 2016 14:42:47 +0100 [thread overview]
Message-ID: <8224a47e-99dd-2a02-3c58-00dba47a2b54@intel.com> (raw)
In-Reply-To: <1469034676-2424-1-git-send-email-zoltan.kiss@schaman.hu>
On 7/20/2016 6:11 PM, Zoltan Kiss wrote:
> Using weak symbols have a few issues with static linking:
>
> - normally the linker searches the .o files already linked, if your weak
> one is there, it won't check if there is a strong version
> - unless the symbol is directly referred, but it's not the right thing to
> rely on
> - or --whole-archive specified in the command line, which pulls in a lot
> of unwanted stuff
> - whole-archive also makes libtool dropping the library from the command
> line, which is what should happen with dynamic linking, but not with
> static (observed on Ubuntu 14.04). This is an important bug if you
> build a static library depending on DPDK
>
> This patch merges the two version and make the behaviour rely on the
> config.
>
> If we can agree in the concept, I can send a series to fix this for the
> other weak functions.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@schaman.hu>
> ---
+ i40e maintainers
I personally prefer macros against weak symbols, because dpdk can be
compiled as static and dynamic libraries, and weak symbols are not
working fine when compiled as static.
>
> Notes:
> v2: fix commit message
>
> drivers/net/i40e/i40e_rxtx.c | 36 +++++++++++++++++++++++++++++++++++-
> drivers/net/i40e/i40e_rxtx_vec.c | 36 ------------------------------------
> 2 files changed, 35 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index d3cfb98..ad34d3a 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -3278,10 +3278,44 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
> }
>
> /* Stubs needed for linkage when CONFIG_RTE_I40E_INC_VECTOR is set to 'n' */
> -int __attribute__((weak))
> +int __attribute__((cold))
> i40e_rx_vec_dev_conf_condition_check(struct rte_eth_dev __rte_unused *dev)
> {
> +#ifndef RTE_LIBRTE_I40E_INC_VECTOR
> return -1;
> +#else
This moves all vector implementation into non-vector file, this is bad
for maintaining. Why not:
in i40e_rxtx.c:
#ifndef RTE_LIBRTE_I40E_INC_VECTOR
i40e_rx_vec_dev_conf_condition_check()
{
return -1;
}
#endif
in i40e_rxtx_vec.c:
No change, keep i40e_rx_vec_dev_conf_condition_check() as it is.
Thanks,
ferruh
next prev parent reply other threads:[~2016-09-14 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:35 [dpdk-dev] [RFC PATCH] i40: remove weak version of i40e_rx_vec_dev_conf_condition_check() Zoltan Kiss
2016-07-20 17:11 ` [dpdk-dev] [PATCH v2] net/i40e: remove weak symbols Zoltan Kiss
2016-07-21 18:58 ` bynes adam
2016-07-22 11:34 ` Zoltan Kiss
2016-07-26 15:10 ` Zoltan Kiss
2016-09-14 13:42 ` Ferruh Yigit [this message]
2016-09-27 13:27 ` Zoltan Kiss
2016-10-10 14:36 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8224a47e-99dd-2a02-3c58-00dba47a2b54@intel.com \
--to=ferruh.yigit@intel.com \
--cc=damarion@cisco.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=matias.elo@nokia-bell-labs.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=zoltan.kiss@schaman.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).