From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Guinan Sun <guinanx.sun@intel.com>, dev@dpdk.org
Cc: Piotr Pietruszewski <piotr.pietruszewski@intel.com>
Subject: Re: [dpdk-dev] [PATCH 01/21] net/ixgbe/base: clear VFMBMEM and toggle VF's Tx queues
Date: Mon, 22 Jun 2020 12:58:38 +0100 [thread overview]
Message-ID: <82635b4a-b256-9ff2-f812-999e3a54828e@intel.com> (raw)
In-Reply-To: <20200612032410.20864-2-guinanx.sun@intel.com>
On 6/12/2020 4:23 AM, Guinan Sun wrote:
> Add a method to clear VFMBMEM memory.
Can you please give some context, what is "VFMBMEM memory", why need to clear
it, etc...?
> Add a method to toggle VF's TX queues as workaround
> for silicon errata.
'toggle' here means enable and disable the Tx queues right?
Will this 'ixgbe_toggle_txdctl()' function used by the driver, if so better to
have that change in the same patch to get the full context.
Are there two changes related to eachother, 'txdctl' & 'VFMBMEM ', if not can
you please seperate them?
>
> Signed-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
<...>
> +/**
> + * ixgbe_clear_mbx - Clear Mailbox Memory
> + * @hw: pointer to the HW structure
> + * @vf_number: id of mailbox to write
> + *
> + * Set VFMBMEM of given VF to 0x0.
> + **/
> +s32 ixgbe_clear_mbx(struct ixgbe_hw *hw, u16 vf_number)
> +{
> + struct ixgbe_mbx_info *mbx = &hw->mbx;
> + s32 ret_val = IXGBE_SUCCESS;
> +
> + DEBUGFUNC("ixgbe_clear_mbx");
> +
> + if (mbx->ops.clear)
> + ret_val = mbx->ops.clear(hw, vf_number);
> +
> + return ret_val;
> +}
> +
> /**
> * ixgbe_poll_for_msg - Wait for message notification
> * @hw: pointer to the HW structure
> @@ -486,6 +506,7 @@ void ixgbe_init_mbx_params_vf(struct ixgbe_hw *hw)
> mbx->ops.check_for_msg = ixgbe_check_for_msg_vf;
> mbx->ops.check_for_ack = ixgbe_check_for_ack_vf;
> mbx->ops.check_for_rst = ixgbe_check_for_rst_vf;
> + mbx->ops.clear = NULL;
If it is not used why 'ixgbe_clear_mbx()' added?
next prev parent reply other threads:[~2020-06-22 11:58 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 3:23 [dpdk-dev] [PATCH 00/21] update ixgbe base code Guinan Sun
2020-06-12 3:23 ` [dpdk-dev] [PATCH 01/21] net/ixgbe/base: clear VFMBMEM and toggle VF's Tx queues Guinan Sun
2020-06-22 11:58 ` Ferruh Yigit [this message]
2020-06-30 1:57 ` Sun, GuinanX
2020-06-12 3:23 ` [dpdk-dev] [PATCH 02/21] net/ixgbe/base: change in the condition for response HI Guinan Sun
2020-06-22 11:58 ` Ferruh Yigit
2020-06-29 9:27 ` Yang, Qiming
2020-06-30 2:17 ` Sun, GuinanX
2020-06-12 3:23 ` [dpdk-dev] [PATCH 03/21] net/ixgbe/base: hange flow for "Apply Update" command Guinan Sun
2020-06-22 11:58 ` Ferruh Yigit
2020-06-30 2:24 ` Sun, GuinanX
2020-06-12 3:23 ` [dpdk-dev] [PATCH 04/21] net/ixgbe/base: x550em 10G NIC driver issue Guinan Sun
2020-06-22 11:59 ` Ferruh Yigit
2020-07-01 2:54 ` Sun, GuinanX
2020-06-12 3:23 ` [dpdk-dev] [PATCH 05/21] net/ixgbe/base: added API for NVM update Guinan Sun
2020-06-22 11:59 ` Ferruh Yigit
2020-06-30 2:37 ` Sun, GuinanX
2020-06-12 3:23 ` [dpdk-dev] [PATCH 06/21] net/ixgbe/base: resolve infinite recursion on PCIe link down Guinan Sun
2020-06-12 3:23 ` [dpdk-dev] [PATCH 07/21] net/ixgbe/base: added register definitions for NVM update Guinan Sun
2020-06-12 3:23 ` [dpdk-dev] [PATCH 08/21] net/ixgbe/base: cleanup spelling mistakes in comments Guinan Sun
2020-06-12 3:23 ` [dpdk-dev] [PATCH 09/21] net/ixgbe/base: remove whitespace in function comments Guinan Sun
2020-06-12 3:23 ` [dpdk-dev] [PATCH 10/21] net/ixgbe/base: move increments after evaluations Guinan Sun
2020-06-22 11:59 ` Ferruh Yigit
2020-06-30 2:51 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 11/21] net/ixgbe/base: modify loop accounting for retries Guinan Sun
2020-06-22 11:59 ` Ferruh Yigit
2020-06-30 2:52 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 12/21] net/ixgbe/base: create dedicated func to restart auto nego Guinan Sun
2020-06-22 11:59 ` Ferruh Yigit
2020-06-12 3:24 ` [dpdk-dev] [PATCH 13/21] net/ixgbe/base: modify Klocwork hits for DDK 7.0 Guinan Sun
2020-06-22 12:00 ` Ferruh Yigit
2020-07-01 4:52 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 14/21] net/ixgbe/base: add defines for min rollback revision fields Guinan Sun
2020-06-22 12:00 ` Ferruh Yigit
2020-07-01 5:08 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 15/21] net/ixgbe/base: remove unnecessary log message FC autonego Guinan Sun
2020-06-12 3:24 ` [dpdk-dev] [PATCH 16/21] net/ixgbe/base: initialize data field in struct buffer Guinan Sun
2020-06-12 3:24 ` [dpdk-dev] [PATCH 17/21] net/ixgbe/base: improve log about autonego being disabled Guinan Sun
2020-06-22 12:00 ` Ferruh Yigit
2020-07-01 5:19 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 18/21] net/ixgbe/base: ipv6 Mask for purpose FDIR VLAN Port Feature Guinan Sun
2020-06-22 12:00 ` Ferruh Yigit
2020-07-01 5:21 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 19/21] net/ixgbe/base: remove default advertising for 2.5G and 5G Guinan Sun
2020-06-22 12:00 ` Ferruh Yigit
2020-07-01 6:24 ` Sun, GuinanX
2020-06-12 3:24 ` [dpdk-dev] [PATCH 20/21] net/ixgbe/base: check Host Interface Return Status Guinan Sun
2020-06-12 3:24 ` [dpdk-dev] [PATCH 21/21] net/ixgbe/base: update version Guinan Sun
2020-06-22 12:01 ` Ferruh Yigit
2020-07-01 6:27 ` Sun, GuinanX
2020-06-15 5:47 ` [dpdk-dev] [PATCH 00/21] update ixgbe base code Zhao1, Wei
2020-06-15 5:59 ` Sun, GuinanX
2020-06-22 2:42 ` Zhao1, Wei
2020-06-22 3:50 ` Zhang, Qi Z
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 00/20] " Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 01/20] net/ixgbe/base: toggle VF's Tx queues Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 02/20] net/ixgbe/base: add support to clear VFMBMEM Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 03/20] net/ixgbe/base: fix host interface shadow RAM read Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 04/20] net/ixgbe/base: change flow for "Apply Update" command Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 05/20] net/ixgbe/base: fix x550em 10G NIC link status report Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 06/20] net/ixgbe/base: resolve infinite recursion on PCIe link down Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 07/20] net/ixgbe/base: added register definitions for NVM update Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 08/20] net/ixgbe/base: cleanup spelling mistakes in comments Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 09/20] net/ixgbe/base: remove whitespace in function comments Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 10/20] net/ixgbe/base: move increments after evaluations Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 11/20] net/ixgbe/base: create dedicated func to restart auto nego Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 12/20] net/ixgbe/base: modify coding style Guinan Sun
2020-07-08 15:26 ` Ferruh Yigit
2020-07-09 7:58 ` Sun, GuinanX
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 13/20] net/ixgbe/base: remove unnecessary log message FC autonego Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 14/20] net/ixgbe/base: initialize data field in struct buffer Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 15/20] net/ixgbe/base: improve log about autonego being disabled Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 16/20] net/ixgbe/base: add ipv6 mask for FDIR feature Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 17/20] net/ixgbe/base: remove default advertising for x550 2.5G/5G Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 18/20] net/ixgbe/base: check host interface return status Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 19/20] net/ixgbe/base: cleanup pre-processor tags Guinan Sun
2020-07-02 3:13 ` [dpdk-dev] [PATCH v2 20/20] net/ixgbe/base: update version Guinan Sun
2020-07-08 0:50 ` [dpdk-dev] [PATCH v2 00/20] update ixgbe base code Zhang, Qi Z
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 00/19] " Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 01/19] net/ixgbe/base: fix host interface shadow RAM read Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 02/19] net/ixgbe/base: change flow for "Apply Update" command Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 03/19] net/ixgbe/base: fix x550em 10G NIC link status report Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 04/19] net/ixgbe/base: resolve infinite recursion on PCIe link down Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 05/19] net/ixgbe/base: added register definitions for NVM update Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 06/19] net/ixgbe/base: cleanup spelling mistakes in comments Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 07/19] net/ixgbe/base: remove whitespace in function comments Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 08/19] net/ixgbe/base: move increments after evaluations Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 09/19] net/ixgbe/base: create dedicated func to restart auto nego Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 10/19] net/ixgbe/base: add typecast for type mismatch Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 11/19] net/ixgbe/base: remove unnecessary return value check Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 12/19] net/ixgbe/base: remove unnecessary log message FC autonego Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 13/19] net/ixgbe/base: initialize data field in struct buffer Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 14/19] net/ixgbe/base: improve log about autonego being disabled Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 15/19] net/ixgbe/base: add ipv6 mask for FDIR feature Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 16/19] net/ixgbe/base: remove default advertising for x550 2.5G/5G Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 17/19] net/ixgbe/base: check host interface return status Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 18/19] net/ixgbe/base: cleanup pre-processor tags Guinan Sun
2020-07-09 8:00 ` [dpdk-dev] [PATCH v3 19/19] net/ixgbe/base: update version Guinan Sun
2020-07-09 10:46 ` [dpdk-dev] [PATCH v3 00/19] update ixgbe base code Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82635b4a-b256-9ff2-f812-999e3a54828e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=piotr.pietruszewski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).