From: "Xu, Qian Q" <qian.q.xu@intel.com>
To: Linhaifeng <haifeng.lin@huawei.com>,
"Xie, Huawei" <huawei.xie@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer
Date: Fri, 30 Jan 2015 08:20:32 +0000 [thread overview]
Message-ID: <82F45D86ADE5454A95A89742C8D1410E01C9FC50@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <54CA3ABF.3010203@huawei.com>
Haifeng
Could you give more information so that we can reproduce your issue? Thanks.
1. What's your dpdk package, based on which branch, with Huawei's vhost-user's patches?
2. What's your step and command to launch vhost sample?
3. What is mz? Your internal tool? I can't yum install mz or download mz tool.
4. As to your test scenario, I understand it in this way: virtio1 in VM1, virtio2 in VM2, then let virtio1 send packages to virtio2, the problem is that after 3 hours, virtio2 can't receive packets, but virtio1 is still sending packets, am I right? So mz is like a packet generator to send packets, right?
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Linhaifeng
Sent: Thursday, January 29, 2015 9:51 PM
To: Xie, Huawei; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer when there is no buffer
On 2015/1/29 21:00, Xie, Huawei wrote:
>
>
>> -----Original Message-----
>> From: Linhaifeng [mailto:haifeng.lin@huawei.com]
>> Sent: Thursday, January 29, 2015 8:39 PM
>> To: Xie, Huawei; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] vhost: notify guest to fill buffer
>> when there is no buffer
>>
>>
>>
>> On 2015/1/29 18:39, Xie, Huawei wrote:
>>
>>>> - if (count == 0)
>>>> + /* If there is no buffers we should notify guest to fill.
>>>> + * This is need when guest use virtio_net driver(not pmd).
>>>> + */
>>>> + if (count == 0) {
>>>> + if (!(vq->avail->flags &
>>>> VRING_AVAIL_F_NO_INTERRUPT))
>>>> + eventfd_write((int)vq->kickfd, 1);
>>>> return 0;
>>>> + }
>>>
>>> Haifeng:
>>> Is it the root cause and is it protocol required?
>>> Could you give a detailed description for that scenario?
>>>
>>
>> I use mz to send data from one VM1 to VM2.The two VM use virtio-net driver.
>> VM1 execute follow script:
>> for((i=0;i<999999999;i++));
>> do
>> mz eth0 -t udp -A 1.1.1.1 -B 1.1.1.2 -a 00:00:00:00:00:01 -b
>> 00:00:00:00:00:02 -c
>> 10000000 -p 512
>> sleep 4
>> done
>>
>> VM2 execute follow command to watch:
>> watch -d ifconfig
>>
>> After many hours VM2 stop to receive data.
>>
>> Could you test it ?
>
>
> We could try next week after I send the whole patch.
> How many hours? Is it reproducible at your side? I inject packets through packet generator to guest for more than ten hours, haven't met issues.
About three hours.
What kind of driver you used in guest?virtio-net-pmd or virtio-net?
> As I said in another mail sent to you, could you dump the status of vring if you still have the spot?
How to dump the status of vring in guest?
> Could you please also reply to that mail?
>
Which mail?
> For the patch, if we have no root cause, I prefer not to apply it, so that we don't send more interrupts than needed to guest to affect performance.
I found that if we add this notify the performance is better(growth of 100kpps when use 64byte UDP packets)
> People could temporarily apply this patch as a work around.
>
> Or anyone
>
OK.I'm also not sure about this bug.I think i should do something to found the real reason.
>
>> --
>> Regards,
>> Haifeng
>
>
>
--
Regards,
Haifeng
next prev parent reply other threads:[~2015-01-30 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 10:30 linhaifeng
2015-01-29 10:39 ` Xie, Huawei
2015-01-29 12:39 ` Linhaifeng
2015-01-29 13:00 ` Xie, Huawei
2015-01-29 13:50 ` Linhaifeng
2015-01-30 8:20 ` Xu, Qian Q [this message]
2015-01-30 10:33 ` Linhaifeng
2015-02-01 6:04 ` Linhaifeng
[not found] ` <82F45D86ADE5454A95A89742C8D1410E01CA1DA3@shsmsx102.ccr.corp.intel.com>
[not found] ` <54CF6BB3.7080002@huawei.com>
[not found] ` <C37D651A908B024F974696C65296B57B0F37C3F7@SHSMSX101.ccr.corp.intel.com>
[not found] ` <54D08AFA.2030404@huawei.com>
[not found] ` <82F45D86ADE5454A95A89742C8D1410E01CA3197@shsmsx102.ccr.corp.intel.com>
[not found] ` <54D0926D.9010304@huawei.com>
2015-02-04 1:38 ` Xu, Qian Q
2015-02-06 4:02 ` Linhaifeng
2015-02-06 5:54 ` Xu, Qian Q
2015-02-06 11:02 ` Linhaifeng
2015-02-07 4:26 ` Linhaifeng
2015-02-09 2:57 ` Xu, Qian Q
2015-02-09 4:11 ` Linhaifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82F45D86ADE5454A95A89742C8D1410E01C9FC50@shsmsx102.ccr.corp.intel.com \
--to=qian.q.xu@intel.com \
--cc=dev@dpdk.org \
--cc=haifeng.lin@huawei.com \
--cc=huawei.xie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).