DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
	Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] ip_chksum not updated in ipsec-secgw application
Date: Mon, 18 Jul 2016 19:23:22 +0530	[thread overview]
Message-ID: <82bd976f-7482-924f-a50a-649bd63d4d65@nxp.com> (raw)
In-Reply-To: <3199592.SCxHWQF8fy@xps13>

On 7/18/2016 6:50 PM, Thomas Monjalon wrote:
> 2016-07-18 13:57, Sergio Gonzalez Monroy:
>> On 18/07/2016 13:41, Akhil Goyal wrote:
>>> In Ipsec-secgw application, while adding the outer IP header,
>>> it seems that the application does not update the checksum value
>>> for outbound packets. This result in incorrect ip->checksum in
>>> the encrypted packet.
> [...]
>>
>> It is intentional. The application is using IP checksum offload
>
> The correct behaviour is to have a software fallback (using rte_ip.h)
> for drivers which do not support checksum offload.
> But given it is just an example, it is normal to have this kind of
> constraint. However I think it should be explained in its doc.
> And a list of tested NICs would be nice to have.
>
Agreed. The driver that I was using did not enable checksum offload. It 
is good to have a fallback option.

  reply	other threads:[~2016-07-18 13:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 12:41 Akhil Goyal
2016-07-18 12:57 ` Sergio Gonzalez Monroy
2016-07-18 13:20   ` Thomas Monjalon
2016-07-18 13:53     ` Akhil Goyal [this message]
2016-07-18 13:57       ` Sergio Gonzalez Monroy
2016-07-18 14:09         ` Thomas Monjalon
2016-07-18 14:25           ` Sergio Gonzalez Monroy
2016-07-18 13:49   ` Akhil Goyal
2016-07-18 14:00     ` Sergio Gonzalez Monroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82bd976f-7482-924f-a50a-649bd63d4d65@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).