From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Remy Horton <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose
Date: Thu, 26 Apr 2018 10:45:42 +0100 [thread overview]
Message-ID: <8317239a-59e3-974c-995a-3d39681013d7@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611531A893C@SHSMSX103.ccr.corp.intel.com>
On 4/26/2018 1:16 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, April 25, 2018 10:15 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Subject: [PATCH] app/testpmd: update start log to be less verbose
>>
>> A per port per queue log is too verbose with multiple port/queue log is
>> longer than full screen, make it less verbose:
>> - Reduced log to only first queue of the port, as a sample
>> - Merged a few lines
>> - Indent queue logs for readability
>>
>> The log becomes as following after update:
>>
>> testpmd> start tx_first
>> io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled,
>> MP over anonymous pages disabled Logical Core 1 (socket 0) forwards
>> packets on 8 streams:
>> RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
>> RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
>> RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
>> RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
>> RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
>> RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
>> RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
>> RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00
>>
>> io packet forwarding packets/burst=32
>> nb forwarding cores=1 - nb forwarding ports=2
>> port 0: RX queue number: 4 Tx queue number: 4
>> Rx offloads=0x1000 Tx offloads=0x0
>> RX queue: 0
>> RX desc=0 - RX free threshold=32
>> RX threshold registers: pthresh=8 hthresh=8 wthresh=0
>> RX Offloads=0x1000
>> TX queue: 0
>> TX desc=0 - TX free threshold=32
>> TX threshold registers: pthresh=32 hthresh=0 wthresh=0
>> TX RS bit threshold=32
>> TX offloads=0x0
>> port 1: RX queue number: 4 Tx queue number: 4
>> Rx offloads=0x1000 Tx offloads=0x0
>> RX queue: 0
>> RX desc=0 - RX free threshold=32
>> RX threshold registers: pthresh=8 hthresh=8 wthresh=0
>> RX Offloads=0x1000
>> TX queue: 0
>> TX desc=0 - TX free threshold=32
>> TX threshold registers: pthresh=32 hthresh=0 wthresh=0
>> TX RS bit threshold=32
>> TX offloads=0x0
>>
>> Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure")
>> Cc: qi.z.zhang@intel.com
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>>
>> Hi Qi,
>>
>> If you are agree with the patch I can squash into original patch.
>
> OK
Thanks, I will squash this one.
>
>>
>> btw, desc numbers are zero, "TX desc=0","RX desc=0", is this correct?
>
> Yes, since the default value of nb_rxd and nb_txd is 0 which mean let device take its default value.
> The patch keep rxtx_config_display just print the configure parameters but not real device configure as before.
> But maybe "TX desc=default" is better for readable?
Instead of "default" what about to display actual value, I assume user will be
interested more with it actual value.
>
> Regards
> Qi
>
next prev parent reply other threads:[~2018-04-26 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 14:15 Ferruh Yigit
2018-04-26 0:16 ` Zhang, Qi Z
2018-04-26 9:45 ` Ferruh Yigit [this message]
2018-04-26 10:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8317239a-59e3-974c-995a-3d39681013d7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=remy.horton@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).