From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] eth: get rid of goto's in rte_eth_dev_detach
Date: Thu, 22 Dec 2016 11:33:40 +0100 [thread overview]
Message-ID: <8501741.XOemNz1Od4@xps13> (raw)
In-Reply-To: <4179dac2-f433-ca40-2f4f-235abab77c6c@intel.com>
2016-12-08 10:25, Ferruh Yigit:
> On 12/8/2016 1:47 AM, Stephen Hemminger wrote:
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -466,27 +466,20 @@ rte_eth_dev_attach(const char *devargs, uint8_t *port_id)
> > int
> > rte_eth_dev_detach(uint8_t port_id, char *name)
> > {
> > - int ret = -1;
> > + int ret;
> >
> > - if (name == NULL) {
> > - ret = -EINVAL;
> > - goto err;
> > - }
> > + if (name == NULL)
> > + return -EINVAL;
> >
> > /* FIXME: move this to eal, once device flags are relocated there */
> > - if (rte_eth_dev_is_detachable(port_id))
> > - goto err;
> > + ret = rte_eth_dev_is_detachable(port_id);
> > + if (ret < 0)
>
> rte_eth_dev_is_detachable() can return 1 to indicate device is not
> detachable.
>
> > + return ret;
It should be
ret = rte_eth_dev_is_detachable(port_id);
if (ret)
return -1;
next prev parent reply other threads:[~2016-12-22 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 1:47 [dpdk-dev] [PATCH 0/2] minor cleanups Stephen Hemminger
2016-12-08 1:47 ` [dpdk-dev] [PATCH 1/2] eth: get rid of goto's in rte_eth_dev_detach Stephen Hemminger
2016-12-08 10:25 ` Ferruh Yigit
2016-12-22 10:33 ` Thomas Monjalon [this message]
2016-12-08 1:47 ` [dpdk-dev] [PATCH 2/2] sched/malloc: remove unnecesary return statements Stephen Hemminger
2016-12-08 10:33 ` Ferruh Yigit
2017-01-09 17:09 ` [dpdk-dev] [PATCH 0/2] minor cleanups Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8501741.XOemNz1Od4@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).