DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names
Date: Wed, 13 Mar 2019 14:21:31 +0000	[thread overview]
Message-ID: <851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com> (raw)
In-Reply-To: <2347388.E9kf87BXsl@xps>

On 3/13/2019 1:59 PM, Thomas Monjalon wrote:
> 13/03/2019 14:41, Ferruh Yigit:
>> On 3/12/2019 10:13 PM, Thomas Monjalon wrote:
>>>> Bruce Richardson (6):
>>>>   eal/bsdapp: rename to freebsd
>>>>   eal/linuxapp: rename to linux
>>>>   build/linux: rename macro from LINUXAPP to LINUX
>>>>   build/freebsd: rename macro from BSDPAPP to FREEBSD
>>>>   build/meson: change linuxapp to linux in meson cross files
>>>>   build: allow linux and freebsd in build configs
>>>
>>> Applied, thanks
>>
>> This has potential to break some automation/scripts since changes the names of
>> the config files:
>> 'make T=x86_64-native-linuxapp-gcc config' becomes
>> 'make T=x86_64-native-linux-gcc config' etc...
>>
>> I suggest highlighting this change in release notes!
> 
> No, the old names should still work.
> Otherwise, it would be an API breakage, which is very bad!
> 

Ah, right config is working, how I hit this is:

$ make T=x86_64-native-linuxapp-gcc cscope
Invalid config: x86_64-native-linuxapp-gcc

'cscope' (and friends) also should be covered ...

  reply	other threads:[~2019-03-13 14:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 16:22 Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 1/6] eal/bsdapp: rename to freebsd Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 2/6] eal/linuxapp: rename to linux Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 3/6] build/linux: rename macro from LINUXAPP to LINUX Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 4/6] build/freebsd: rename macro from BSDPAPP to FREEBSD Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 5/6] build/meson: change linuxapp to linux in meson cross files Bruce Richardson
2019-03-06 16:22 ` [dpdk-dev] [PATCH 6/6] build: allow linux and freebsd in build configs Bruce Richardson
2019-03-09  0:57 ` [dpdk-dev] [RFC PATCH 0/6] change legacy linuxapp/bsdapp names Thomas Monjalon
2019-03-12 22:13 ` Thomas Monjalon
2019-03-13 13:41   ` Ferruh Yigit
2019-03-13 13:59     ` Thomas Monjalon
2019-03-13 14:21       ` Ferruh Yigit [this message]
2019-03-13 14:43         ` Bruce Richardson
2019-03-13 15:14           ` Ferruh Yigit
2019-03-13 15:20             ` Bruce Richardson
2019-03-13 15:02         ` Bruce Richardson
2019-03-13 15:11           ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=851ec589-621b-c31e-7198-cd3b9e5ddd68@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).