From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
huawei.xie@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: fix off-by-one error on nr_desc check
Date: Mon, 25 Jul 2016 17:47:38 +0200 [thread overview]
Message-ID: <8594081.HlfyGW5kfQ@xps13> (raw)
In-Reply-To: <20160725152412.GS28708@yliu-dev.sh.intel.com>
2016-07-25 23:24, Yuanhan Liu:
> On Mon, Jul 25, 2016 at 04:09:58PM +0200, Maxime Coquelin wrote:
> > nr_desc is not an index but the number of descriptors,
> > so can be equal to the virtqueue size.
> >
> > Fixes: a436f53ebfeb ("vhost: avoid dead loop chain")
> >
> > Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks for catching it!
>
> > ---
> > Hi Yuanhan,
> >
> > I faced the bug while testing my indirect descriptor patch, it happens
> > as soon as the number of chained descritors is above 2.
> >
> > But the bug may in theory also be faced with normal descriptors,
>
> In theory, yes, and only in one case, that there is a Tx has 256
> descriptors chained. If that happens, I doubt things work well.
> So I would say it just happens __in theory__.
>
> > so it might
> > be good to have it 16.07?
>
> Even though, it apparently fixes a bug, so I think we could have it
> for 16.07.
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Applied, thanks
prev parent reply other threads:[~2016-07-25 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 14:09 Maxime Coquelin
2016-07-25 15:24 ` Yuanhan Liu
2016-07-25 15:28 ` Maxime Coquelin
2016-07-25 15:47 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8594081.HlfyGW5kfQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=huawei.xie@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).