From: "Liu, Yong" <yong.liu@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/distributor: fix Rx thread logic for zero packets
Date: Sun, 17 Jul 2016 14:05:17 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E22258EF0@SHSMSX103.ccr.corp.intel.com> (raw)
Tested-by: Marvin Liu <yong.liu@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Thursday, July 14, 2016 11:49 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH] examples/distributor: fix Rx thread logic for
> zero packets
>
> From: Reshma Pattan <reshma.pattan@intel.com>
>
> Zero packets can be returned by rte_eth_rx_burst() and
> rte_distributor_returned_pkts() inside lcore_rx(), so
> for zero packet scenario instead of proceeding to
> next operations we should continue to the next iteration of the
> loop to avoid unnecessary processing overhead which is causing
> rx packets to be dropped and hence distributor failing to forward the
> packets.
>
> Fixes: 07db4a97 ("examples/distributor: new sample app")
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> examples/distributor/main.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/examples/distributor/main.c b/examples/distributor/main.c
> index 24857f2..537cee1 100644
> --- a/examples/distributor/main.c
> +++ b/examples/distributor/main.c
> @@ -221,14 +221,22 @@ lcore_rx(struct lcore_params *p)
> struct rte_mbuf *bufs[BURST_SIZE*2];
> const uint16_t nb_rx = rte_eth_rx_burst(port, 0, bufs,
> BURST_SIZE);
> + if (unlikely(nb_rx == 0)) {
> + if (++port == nb_ports)
> + port = 0;
> + continue;
> + }
> app_stats.rx.rx_pkts += nb_rx;
>
> rte_distributor_process(d, bufs, nb_rx);
> const uint16_t nb_ret = rte_distributor_returned_pkts(d,
> bufs, BURST_SIZE*2);
> app_stats.rx.returned_pkts += nb_ret;
> - if (unlikely(nb_ret == 0))
> + if (unlikely(nb_ret == 0)) {
> + if (++port == nb_ports)
> + port = 0;
> continue;
> + }
>
> uint16_t sent = rte_ring_enqueue_burst(r, (void *)bufs,
> nb_ret);
> app_stats.rx.enqueued_pkts += sent;
> --
> 2.5.0
next reply other threads:[~2016-07-17 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 14:05 Liu, Yong [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-14 15:48 Reshma Pattan
2016-07-15 9:59 ` De Lara Guarch, Pablo
2016-07-15 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E22258EF0@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).