From: "Liu, Yong" <yong.liu@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] mem: fix index for unmapping segments on failure
Date: Fri, 4 May 2018 08:13:01 +0000 [thread overview]
Message-ID: <86228AFD5BCD8E4EBFD2B90117B5E81E630330EC@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <556d606e3af8ab32e920611d166a0154e472fe25.1525342009.git.anatoly.burakov@intel.com>
Tested-by: Marvin Liu <yong.liu@intel.com>
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Thursday, May 03, 2018 6:11 PM
> To: dev@dpdk.org
> Cc: Liu, Yong <yong.liu@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [PATCH 1/3] mem: fix index for unmapping segments on failure
>
> Segment index was calculated incorrectly, causing free_seg to
> attempt to free segments that do not exist.
>
> Fixes: a5ff05d60fc5 ("mem: support unmapping pages at runtime")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_memalloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> index 360d8f7..c441c89 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> @@ -735,8 +735,7 @@ alloc_seg_walk(const struct rte_memseg_list *msl, void
> *arg)
> &cur_msl->memseg_arr;
>
> tmp = rte_fbarray_get(arr, j);
> - if (free_seg(tmp, wa->hi, msl_idx,
> - start_idx + j)) {
> + if (free_seg(tmp, wa->hi, msl_idx, j)) {
> RTE_LOG(ERR, EAL, "Cannot free page\n");
> continue;
> }
> --
> 2.7.4
next prev parent reply other threads:[~2018-05-04 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:11 Anatoly Burakov
2018-05-03 10:11 ` [dpdk-dev] [PATCH 2/3] memalloc: fix wrong return value on freeing segment on fail Anatoly Burakov
2018-05-10 16:03 ` Ananyev, Konstantin
2018-05-03 10:11 ` [dpdk-dev] [PATCH 3/3] memalloc: fix unmapping and marking segments as free Anatoly Burakov
2018-05-10 17:03 ` Ananyev, Konstantin
2018-05-04 8:13 ` Liu, Yong [this message]
2018-05-10 17:07 ` [dpdk-dev] [PATCH 1/3] mem: fix index for unmapping segments on failure Ananyev, Konstantin
2018-05-14 1:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86228AFD5BCD8E4EBFD2B90117B5E81E630330EC@SHSMSX103.ccr.corp.intel.com \
--to=yong.liu@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).