From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Rasesh Mody <rasesh.mody@cavium.com>, <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH] net/qede/base: fix freebsd compilation
Date: Mon, 23 Jan 2017 09:43:48 +0300 [thread overview]
Message-ID: <8698363e-60a6-0eba-e0f2-821c1f409798@solarflare.com> (raw)
In-Reply-To: <1485147758-21809-1-git-send-email-rasesh.mody@cavium.com>
On 01/23/2017 08:02 AM, Rasesh Mody wrote:
> This patch addresses compilation errors on FreeBSD 11.0 clang 3.8.0.
>
> Fixes: ec94dbc57362 ("qede: add base driver")
>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
> drivers/net/qede/base/ecore_init_fw_funcs.c | 2 +-
> drivers/net/qede/base/reg_addr.h | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/qede/base/ecore_init_fw_funcs.c b/drivers/net/qede/base/ecore_init_fw_funcs.c
> index a5437b5..77f9152 100644
> --- a/drivers/net/qede/base/ecore_init_fw_funcs.c
> +++ b/drivers/net/qede/base/ecore_init_fw_funcs.c
> @@ -89,7 +89,7 @@ enum CmInterfaceEnum {
> #define QM_STOP_CMD_STRUCT_SIZE 2
> #define QM_STOP_CMD_PAUSE_MASK_OFFSET 0
> #define QM_STOP_CMD_PAUSE_MASK_SHIFT 0
> -#define QM_STOP_CMD_PAUSE_MASK_MASK -1
> +#define QM_STOP_CMD_PAUSE_MASK_MASK 0xffffffff /* @DPDK */
> #define QM_STOP_CMD_GROUP_ID_OFFSET 1
> #define QM_STOP_CMD_GROUP_ID_SHIFT 16
> #define QM_STOP_CMD_GROUP_ID_MASK 15
> diff --git a/drivers/net/qede/base/reg_addr.h b/drivers/net/qede/base/reg_addr.h
> index ab88671..3c369aa 100644
> --- a/drivers/net/qede/base/reg_addr.h
> +++ b/drivers/net/qede/base/reg_addr.h
> @@ -30,7 +30,7 @@
> 24
>
> #define CDU_REG_CID_ADDR_PARAMS_NCIB ( \
> - 0xff << 24)
> + 0xffUL << 24) /* @DPDK */
>
> #define XSDM_REG_OPERATION_GEN \
> 0xf80408UL
> @@ -436,11 +436,11 @@
> #define NIG_REG_LLH_FUNC_FILTER_VALUE 0x501a00UL
> #define XMAC_REG_CTRL_TX_EN (0x1 << 0)
> #define XMAC_REG_CTRL_RX_EN (0x1 << 1)
> -#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xff << 24)
> +#define CDU_REG_SEGMENT0_PARAMS_T0_TID_SIZE (0xffUL << 24) /* @DPDK */
> #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE (0xff << 16)
> #define CDU_REG_SEGMENT0_PARAMS_T0_TID_BLOCK_WASTE_SHIFT 16
> #define CDU_REG_SEGMENT1_PARAMS_T1_TID_BLOCK_WASTE (0xff << 16)
> -#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xff << 24)
> +#define CDU_REG_SEGMENT1_PARAMS_T1_TID_SIZE (0xffUL << 24) /* @DPDK */
> #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK (0xfff << 0)
> #define CDU_REG_SEGMENT1_PARAMS_T1_NUM_TIDS_IN_BLOCK_SHIFT 0
> #define CDU_REG_SEGMENT0_PARAMS_T0_NUM_TIDS_IN_BLOCK (0xfff << 0)
FreeBSD build is OK for me with the patch applied.
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2017-01-23 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 5:02 Rasesh Mody
2017-01-23 6:43 ` Andrew Rybchenko [this message]
2017-01-23 10:21 ` Thomas Monjalon
2017-01-23 13:25 ` Ferruh Yigit
2017-01-23 13:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8698363e-60a6-0eba-e0f2-821c1f409798@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasesh.mody@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).