DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Ye Xiaolong" <xiaolong.ye@intel.com>
Cc: "David Marchand" <david.marchand@redhat.com>,
	"Beilei Xing" <beilei.xing@intel.com>,
	"Qi Zhang" <qi.z.zhang@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log
Date: Thu, 12 Sep 2019 14:56:30 +0200	[thread overview]
Message-ID: <86F54302-F156-4F8F-9C06-2393F3A38EC1@redhat.com> (raw)
In-Reply-To: <20190912124049.GA71525@intel.com>

On 12 Sep 2019, at 14:40, Ye Xiaolong wrote:

> On 09/12, David Marchand wrote:
>> On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron <echaudro@redhat.com> 
>> wrote:
>>>
>>> When receiving the unsupported AQ messages, it's taken as an
>>> error. It's not appropriate and triggers too much unnecessary print.
>>>
>>> This commit is similar to commit e130425300b0 ("net/i40e: downgrade
>>> unnecessary error log") which made the same change for the PF 
>>> instance.
>>>
>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
>>> ---
>>>  drivers/net/i40e/i40e_ethdev_vf.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c 
>>> b/drivers/net/i40e/i40e_ethdev_vf.c
>>> index c77b30c54..7b1d485c6 100644
>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c
>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
>>> @@ -1411,7 +1411,7 @@ i40evf_handle_aq_msg(struct rte_eth_dev *dev)
>>>                         }
>>>                         break;
>>>                 default:
>>> -                       PMD_DRV_LOG(ERR, "Request %u is not 
>>> supported yet",
>>> +                       PMD_DRV_LOG(DEBUG, "Request %u is not 
>>> supported yet",
>>>                                     aq_opc);
>>>                         break;
>>>                 }
>>> --
>>> 2.18.1
>>>
>>
>> Reviewed-by: David Marchand <david.marchand@redhat.com>
>>
>>
>> --
>> David Marchand
>
> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Applied to dpdk-next-net-intel.

Thanks David/Ye

  reply	other threads:[~2019-09-12 12:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 10:38 Eelco Chaudron
2019-09-12 12:02 ` David Marchand
2019-09-12 12:40   ` Ye Xiaolong
2019-09-12 12:56     ` Eelco Chaudron [this message]
2019-09-13  9:00     ` Eelco Chaudron
2019-09-13 13:24       ` Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86F54302-F156-4F8F-9C06-2393F3A38EC1@redhat.com \
    --to=echaudro@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).