From: Ferruh Yigit <ferruh.yigit@intel.com>
To: aviadye@dev.mellanox.co.il, dev@dpdk.org,
sergio.gonzalez.monroy@intel.com, pablo.de.lara.guarch@intel.com,
aviadye@mellanox.com
Cc: borisp@mellanox.com, akhil.goyal@nxp.com, hemant.agrawal@nxp.com,
radu.nicolau@intel.com, declan.doherty@intel.com,
liranl@mellanox.com, nelio.laranjeiro@6wind.com,
thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling
Date: Mon, 23 Oct 2017 15:32:52 -0700 [thread overview]
Message-ID: <86d682d7-b0e7-0f02-7260-e2aca3396704@intel.com> (raw)
In-Reply-To: <1508439233-17981-1-git-send-email-aviadye@dev.mellanox.co.il>
On 10/19/2017 11:53 AM, aviadye@dev.mellanox.co.il wrote:
> From: Aviad Yehezkel <aviadye@mellanox.com>
Hi Aviad,
What do you think using RTE_SET_USED() as done in other samples, we know those
variables may not be used if PMDs are not defined, no need to make code more
complex.
Like:
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7504,6 +7504,9 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
ret = rte_pmd_bnxt_set_vf_rxmode(res->port_id, res->vf_id,
rx_mode, (uint8_t)is_on);
#endif
+
+ RTE_SET_USED(is_on);
+
if (ret < 0)
printf("bad VF receive mode parameter, return code = %d \n",
ret);
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -3197,6 +3197,10 @@ set_vf_rate_limit(portid_t port_id, uint16_t vf,
uint16_t rate, uint64_t q_msk)
if (diag == 0)
return diag;
+ RTE_SET_USED(vf);
+ RTE_SET_USED(rate);
+ RTE_SET_USED(q_msk);
+
printf("set_vf_rate_limit for port_id=%d failed diag=%d\n",
port_id, diag);
return diag;
>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> Signed-off-by: Nicolai Radu <radu.nicolai@intel.com>
<...>
next prev parent reply other threads:[~2017-10-23 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 18:53 aviadye
2017-10-23 22:32 ` Ferruh Yigit [this message]
2017-10-24 14:48 ` [dpdk-dev] [PATCH v2] app/testpmd: compile without ixgbe and bnxt pmds aviadye
2017-10-24 18:31 ` Ferruh Yigit
2017-10-24 18:46 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d682d7-b0e7-0f02-7260-e2aca3396704@intel.com \
--to=ferruh.yigit@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=aviadye@dev.mellanox.co.il \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=liranl@mellanox.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).