From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: Fix bug with duplicate filter pattern for flow director
Date: Thu, 22 Mar 2018 18:46:56 +0000 [thread overview]
Message-ID: <8712ecbf-57d5-121f-2171-2a573a49871f@intel.com> (raw)
In-Reply-To: <20180222025822.18421-1-somnath.kotur@broadcom.com>
On 2/22/2018 2:58 AM, Somnath Kotur wrote:
Please start with lowercase after "net/bnxt: fix"
> When user reissues same flow director cmd with a different queue
> update the existing filter to redirect flow to the new desired
> queue as destination just like the other filters like 5 tuple and
> generic flow.
Can you please add a fixes line?
Also ./devtools/check-git-log.sh complains about long title, what about
something like (just a sample):
"net/bnxt: fix flow director with same cmd different queue"
>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
<...>
> @@ -2436,11 +2440,32 @@ bnxt_fdir_filter(struct rte_eth_dev *dev,
> goto free_filter;
> filter->filter_type = HWRM_CFA_NTUPLE_FILTER;
>
> - match = bnxt_match_fdir(bp, filter);
> + if (fdir->action.behavior == RTE_ETH_FDIR_REJECT)
> + vnic = STAILQ_FIRST(&bp->ff_pool[0]);
> + else
> + vnic =
> + STAILQ_FIRST(&bp->ff_pool[fdir->action.rx_queue]);
Is this done because of column limit? If so I would prefer a few extra chars
instead of this assignment.
btw, not related to this patch, but in this switch there are a few "/*
FALLTHROUGH */" comments but they may not be required (or wrong), can you please
check.
<...>
next prev parent reply other threads:[~2018-03-22 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 2:58 Somnath Kotur
2018-03-22 18:46 ` Ferruh Yigit [this message]
2018-03-23 3:34 ` Somnath Kotur
2018-03-23 10:41 ` Ferruh Yigit
2018-03-23 11:41 ` Somnath Kotur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8712ecbf-57d5-121f-2171-2a573a49871f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).