From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: Gagandeep Singh <g.singh@nxp.com>,
dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Cc: Vanshika Shukla <vanshika.shukla@nxp.com>
Subject: Re: [PATCH v2 5/5] net/dpaa: Fix coverity issue
Date: Thu, 9 Oct 2025 15:19:16 +0530 [thread overview]
Message-ID: <87aaf909-e17c-47c7-a83e-acf61d2fdb03@oss.nxp.com> (raw)
In-Reply-To: <20251008043519.2461707-6-g.singh@nxp.com>
On 08-10-2025 10:05, Gagandeep Singh wrote:
> From: Vanshika Shukla <vanshika.shukla@nxp.com>
>
> Fix Resource leak CID:362787 issue reported by external coverity tool.
This is internal NXP coverity issue? can you also add details about the
issue here?
>
> Signed-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>
> ---
> drivers/net/dpaa/dpaa_flow.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dpaa/dpaa_flow.c b/drivers/net/dpaa/dpaa_flow.c
> index 2a22b23c8f..417b9b6fbb 100644
> --- a/drivers/net/dpaa/dpaa_flow.c
> +++ b/drivers/net/dpaa/dpaa_flow.c
> @@ -1,5 +1,5 @@
> /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright 2017-2019,2021-2024 NXP
> + * Copyright 2017-2019,2021-2025 NXP
> */
>
> /* System headers */
> @@ -889,9 +889,9 @@ int dpaa_fm_init(void)
> /* FM PCD Enable */
> ret = fm_pcd_enable(pcd_handle);
> if (ret) {
> - fm_close(fman_handle);
> - fm_pcd_close(pcd_handle);
> DPAA_PMD_ERR("fm_pcd_enable: Failed");
> + fm_pcd_close(pcd_handle);
> + fm_close(fman_handle);
> return -1;
> }
>
next prev parent reply other threads:[~2025-10-09 9:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 5:00 [PATCH 0/5] DPAA specific changes Gagandeep Singh
2025-10-07 5:00 ` [PATCH 1/5] bus/dpaa: add FQ shutdown and improve logging Gagandeep Singh
2025-10-07 5:00 ` [PATCH 2/5] net/dpaa: Support IEEE1588 by timesync API Gagandeep Singh
2025-10-07 5:00 ` [PATCH 3/5] bus/dpaa: Disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-07 5:00 ` [PATCH 4/5] bus/dpaa: Set max push RXQ number Gagandeep Singh
2025-10-07 5:00 ` [PATCH 5/5] net/dpaa: Fix coverity issue Gagandeep Singh
2025-10-08 4:35 ` [PATCH v2 0/5] DPAA specific changes Gagandeep Singh
2025-10-08 4:35 ` [PATCH v2 1/5] bus/dpaa: add FQ shutdown and improve logging Gagandeep Singh
2025-10-09 9:44 ` Hemant Agrawal
2025-10-08 4:35 ` [PATCH v2 2/5] net/dpaa: Support IEEE1588 by timesync API Gagandeep Singh
2025-10-08 4:35 ` [PATCH v2 3/5] bus/dpaa: Disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-08 4:35 ` [PATCH v2 4/5] bus/dpaa: Set max push RXQ number Gagandeep Singh
2025-10-08 4:35 ` [PATCH v2 5/5] net/dpaa: Fix coverity issue Gagandeep Singh
2025-10-09 9:49 ` Hemant Agrawal [this message]
2025-10-13 7:08 ` Gagandeep Singh
2025-10-14 10:17 ` [PATCH v3 0/5] DPAA specific changes Gagandeep Singh
2025-10-14 10:17 ` [PATCH v3 1/5] bus/dpaa: add FQ shutdown and improve logging Gagandeep Singh
2025-10-15 15:32 ` Hemant Agrawal
2025-10-14 10:17 ` [PATCH v3 2/5] net/dpaa: Support IEEE1588 by timesync API Gagandeep Singh
2025-10-14 10:17 ` [PATCH v3 3/5] bus/dpaa: Disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-14 10:17 ` [PATCH v3 4/5] bus/dpaa: Set max push RXQ number Gagandeep Singh
2025-10-14 10:17 ` [PATCH v3 5/5] net/dpaa: fix resource leak coverity issue Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 0/6] DPAA specific changes Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 1/6] bus/dpaa: add FQ shutdown and improve logging Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 2/6] bus/dpaa: imrpove DPAA bus qman logging Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 3/6] net/dpaa: Support IEEE1588 by timesync API Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 4/6] bus/dpaa: Disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 5/6] bus/dpaa: Set max push RXQ number Gagandeep Singh
2025-10-17 4:42 ` [PATCH v4 6/6] net/dpaa: fix resource leak coverity issue Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 0/6] DPAA specific changes Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 1/6] bus/dpaa: fix and add FQ shutdown Gagandeep Singh
2025-10-18 1:51 ` Stephen Hemminger
2025-10-17 4:48 ` [PATCH v5 2/6] bus/dpaa: imrpove DPAA bus qman logging Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 3/6] net/dpaa: Support IEEE1588 by timesync API Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 4/6] bus/dpaa: Disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 5/6] bus/dpaa: Set max push RXQ number Gagandeep Singh
2025-10-18 1:52 ` Stephen Hemminger
2025-10-24 5:37 ` Gagandeep Singh
2025-10-17 4:48 ` [PATCH v5 6/6] net/dpaa: fix resource leak coverity issue Gagandeep Singh
2025-10-18 1:53 ` Stephen Hemminger
2025-10-17 5:16 ` [PATCH v5 0/6] DPAA specific changes Hemant Agrawal
2025-10-18 1:49 ` Stephen Hemminger
2025-10-24 6:19 ` [PATCH v6 " Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 1/6] bus/dpaa: fix FQ shutdown to do proper cleanup of frame queues Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 2/6] bus/dpaa: improve DPAA bus qman logging Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 3/6] net/dpaa: support IEEE1588 by timesync API Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 4/6] bus/dpaa: disable qman Invalid Enqueue State interrupt Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 5/6] bus/dpaa: set max push RXQ number Gagandeep Singh
2025-10-24 6:19 ` [PATCH v6 6/6] net/dpaa: fix resource leak coverity issue Gagandeep Singh
2025-10-25 18:07 ` [PATCH v6 0/6] DPAA specific changes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaf909-e17c-47c7-a83e-acf61d2fdb03@oss.nxp.com \
--to=hemant.agrawal@oss.nxp.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=vanshika.shukla@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).