From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: zhihong.wang@intel.com, tiwei.bie@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/7] vhost: translate iovas at vectors fill time
Date: Thu, 21 Jun 2018 16:45:39 +0200 [thread overview]
Message-ID: <87b15952-8be9-91b2-c079-f486add7e40f@redhat.com> (raw)
In-Reply-To: <20180608103913.11517-5-maxime.coquelin@redhat.com>
On 06/08/2018 12:39 PM, Maxime Coquelin wrote:
> @@ -584,7 +578,8 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
> vq->last_avail_idx + num_buffers);
>
> if (copy_mbuf_to_desc(dev, vq, pkts[pkt_idx],
> - buf_vec, num_buffers) < 0) {
> + buf_vec, num_buffers,
> + nr_vec) < 0) {
FYI,there is a bug here. num_buffers and nr_vec must be swapped:
static __rte_always_inline int
copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
struct rte_mbuf *m, struct buf_vector *buf_vec,
uint16_t num_buffers)
It can be reproduce with Kernel driver with mrg OFF and with offloads
ON.
Maxime
> vq->shadow_used_idx -= num_buffers;
next prev parent reply other threads:[~2018-06-21 14:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 10:39 [dpdk-dev] [PATCH 0/7] vhost: generalize buffer vectors Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 1/7] vhost: use shadow used ring in dequeue path Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 2/7] vhost: make gpa to hpa failure an error Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 3/7] vhost: use buffer vectors in dequeue path Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 4/7] vhost: translate iovas at vectors fill time Maxime Coquelin
2018-06-21 14:45 ` Maxime Coquelin [this message]
2018-06-08 10:39 ` [dpdk-dev] [PATCH 5/7] vhost: improve prefetching in dequeue path Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 6/7] vhost: prefetch first descriptor " Maxime Coquelin
2018-06-08 10:39 ` [dpdk-dev] [PATCH 7/7] vhost: improve prefetching in enqueue path Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87b15952-8be9-91b2-c079-f486add7e40f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).