From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Su, Simei" <simei.su@intel.com>,
Luca Boccassi <bluca@debian.org>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: RE: [PATCH v4] net/ice: improve performance of RX timestamp offload
Date: Thu, 24 Mar 2022 11:51:53 +0000 [thread overview]
Message-ID: <87ea19805e604ca5b85366cf11028a09@intel.com> (raw)
In-Reply-To: <4d81601b-6aa5-3746-a888-7a290e071997@redhat.com>
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Thursday, March 24, 2022 7:17 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Wenjun1
> <wenjun1.wu@intel.com>; dev@dpdk.org; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Su, Simei
> <simei.su@intel.com>; Luca Boccassi <bluca@debian.org>; Christian Ehrhardt
> <christian.ehrhardt@canonical.com>
> Subject: Re: [PATCH v4] net/ice: improve performance of RX timestamp
> offload
>
> On 24/03/2022 09:09, Zhang, Qi Z wrote:
> >
> >
> >> -----Original Message-----
> >> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> >> Sent: Monday, February 28, 2022 3:36 PM
> >> To: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> >> <qiming.yang@intel.com>
> >> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Su, Simei
> >> <simei.su@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> >> Subject: [PATCH v4] net/ice: improve performance of RX timestamp
> >> offload
> >>
> >> Previously, each time a burst of packets is received, SW reads HW
> >> register and assembles it and the timestamp from descriptor together
> >> to get the complete 64 bits timestamp.
> >>
> >> This patch optimizes the algorithm. The SW only needs to check the
> >> monotonicity of the low 32bits timestamp to avoid crossing borders.
> >> Each time before SW receives a burst of packets, it should check the
> >> time difference between current time and last update time to avoid
> >> the low 32 bits timestamp cycling twice.
> >>
> >> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> >
> > Added cc stable
> >
>
> Hi Qi. The DPDK documentation has guidance about what should be
> backported to LTS [0] and distinguishes between fixes and performance
> improvements. Please try and stick with this when applying patches or let LTS
> maintainers know if there is a debatable case.
Thanks for the comments
Yes, actually this is about a 50% ~ 70% performance improvement, which maybe critical for some performance sensitive use cases.(e.g. network forensics)
So I'd like to defend with below case
An existing feature in LTS is not usable as intended without it.
Thanks
Qi
>
> thanks,
> Kevin.
>
> [0]
> http://doc.dpdk.org/guides-21.11/contributing/stable.html#what-changes-
> should-be-backported
>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> >
> > Applied to dpdk-next-net-intel.
> >
> > Thanks
> > Qi
> >
>
next prev parent reply other threads:[~2022-03-24 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 5:16 [PATCH v1] " Wenjun Wu
2022-02-22 5:50 ` [PATCH v2] " Wenjun Wu
2022-02-22 6:26 ` [PATCH v3] " Wenjun Wu
2022-02-28 7:36 ` [PATCH v4] " Wenjun Wu
2022-03-01 11:07 ` Zhang, Qi Z
2022-03-24 9:09 ` Zhang, Qi Z
2022-03-24 11:16 ` Kevin Traynor
2022-03-24 11:51 ` Zhang, Qi Z [this message]
2022-03-24 12:17 ` Kevin Traynor
2022-03-24 13:05 ` Zhang, Qi Z
2022-03-24 13:44 ` Kevin Traynor
2022-03-24 13:57 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ea19805e604ca5b85366cf11028a09@intel.com \
--to=qi.z.zhang@intel.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=ktraynor@redhat.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).