From: Sirshak Das <sirshak.das@arm.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "Gavin Hu" <gavin.hu@arm.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Sirshak Das" <sirshak.das@arm.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Shahaf Shuler" <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue
Date: Tue, 15 May 2018 12:52:56 -0500 [thread overview]
Message-ID: <87zi10rekn.fsf@arm.com> (raw)
In-Reply-To: <AF48DD10-7195-46E7-85F0-D0E9F2CC1775@mellanox.com>
Hi Yongseok,
We will make the commit message more verbose.
As for the error: This is a clang compiler issue:
drivers/net/mlx5/mlx5_rxtx_vec.c:37:
/home/sirdas/code/commitc/dpdk-stable-18.02.1/drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments provided to function-like macro invocation
(uint16x8_t) { 0, 0, cs_flags,
rte_cpu_to_be_16(len),
Thank you
Sirshak Das.
Yongseok Koh writes:
>> On May 15, 2018, at 2:23 AM, Gavin Hu <gavin.hu@arm.com> wrote:
>
> The title should start from 'net/mlx5: ...' and please be more specific why
> that pair of parentheses is needed. Add more commit messages and it'd be
> better to add the error messages like you do in the other commit.
>
> To me, it still looks unnecessary.
>
> Thanks,
> Yongseok
>
>> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
>> Signed-off-by: Sirshak Das <sirshak.das@arm.com>
>> Reviewed-by: Phil Yang <Phil.Yang@arm.com>
>> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> ---
>> drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
>> index 2673d6b..71a5eaf 100644
>> --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
>> +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
>> @@ -167,8 +167,8 @@ txq_scatter_v(struct mlx5_txq_data *txq, struct rte_mbuf **pkts,
>> vst1q_u8((void *)t_wqe, ctrl);
>> /* Fill ESEG in the header. */
>> vst1q_u16((void *)(t_wqe + 1),
>> - (uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len),
>> - 0, 0, 0, 0 });
>> + ((uint16x8_t) { 0, 0, cs_flags, rte_cpu_to_be_16(len),
>> + 0, 0, 0, 0 }));
>> txq->wqe_ci = wqe_ci;
>> }
>> if (!n)
>> @@ -300,10 +300,10 @@ txq_burst_v(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, uint16_t pkts_n,
>> vst1q_u8((void *)t_wqe, ctrl);
>> /* Fill ESEG in the header. */
>> vst1q_u8((void *)(t_wqe + 1),
>> - (uint8x16_t) { 0, 0, 0, 0,
>> - cs_flags, 0, 0, 0,
>> - 0, 0, 0, 0,
>> - 0, 0, 0, 0 });
>> + ((uint8x16_t) { 0, 0, 0, 0,
>> + cs_flags, 0, 0, 0,
>> + 0, 0, 0, 0,
>> + 0, 0, 0, 0 }));
>> #ifdef MLX5_PMD_SOFT_COUNTERS
>> txq->stats.opackets += pkts_n;
>> #endif
>> --
>> 2.1.4
>>
next prev parent reply other threads:[~2018-05-15 17:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 8:28 [dpdk-dev] [PATCH 0/4] *** fix native clang compiling errors on ARM64 *** Gavin Hu
2018-05-15 8:28 ` [dpdk-dev] [PATCH 1/4] app: add LDFLAGS -latomic to link atomic lib Gavin Hu
2018-05-15 9:00 ` Bruce Richardson
2018-05-15 10:10 ` Gavin Hu
2018-05-15 9:07 ` Jerin Jacob
2018-05-15 8:28 ` [dpdk-dev] [PATCH 2/4] Driver/Mellanox: fix PMD compiling issue Gavin Hu
2018-05-15 9:11 ` Jerin Jacob
2018-05-15 8:28 ` [dpdk-dev] [PATCH 3/4] cryptodev: fix the clang " Gavin Hu
2018-05-15 8:28 ` [dpdk-dev] [PATCH 4/4] ifpgai_rawdev: " Gavin Hu
2018-05-15 9:23 ` [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib Gavin Hu
2018-05-15 9:23 ` [dpdk-dev] [PATCH v2 2/4] Driver/Mellanox: fix PMD compiling issue Gavin Hu
2018-05-15 17:05 ` Yongseok Koh
2018-05-15 17:52 ` Sirshak Das [this message]
2018-05-15 18:38 ` Yongseok Koh
2018-05-15 9:23 ` [dpdk-dev] [PATCH v2 3/4] cryptodev: fix the clang " Gavin Hu
2018-05-15 11:41 ` Jerin Jacob
2018-05-15 13:34 ` De Lara Guarch, Pablo
2018-05-15 9:23 ` [dpdk-dev] [PATCH v2 4/4] ifpgai_rawdev: " Gavin Hu
2018-05-16 5:13 ` Jerin Jacob
2018-05-15 11:38 ` [dpdk-dev] [PATCH v2 1/4] app: add LDFLAGS -latomic to link atomic lib Jerin Jacob
2018-05-16 6:08 ` [dpdk-dev] [PATCH v3 1/3] net/mlx5: fix the clang compiling issue Gavin Hu
2018-05-16 6:08 ` [dpdk-dev] [PATCH v3 2/3] eventdev: " Gavin Hu
2018-05-16 6:08 ` [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: " Gavin Hu
2018-05-16 6:45 ` Jerin Jacob
2018-05-17 1:47 ` Gavin Hu
2018-05-20 22:28 ` Thomas Monjalon
2018-05-17 2:46 ` [dpdk-dev] [PATCH v4 1/3] net/mlx5: " Gavin Hu
2018-05-17 2:46 ` [dpdk-dev] [PATCH v4 2/3] eventdev: " Gavin Hu
2018-05-17 2:46 ` [dpdk-dev] [PATCH v4 3/3] raw/ifpga: " Gavin Hu
2018-05-20 23:02 ` [dpdk-dev] [PATCH v4 1/3] net/mlx5: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi10rekn.fsf@arm.com \
--to=sirshak.das@arm.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).