From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Kevin Traynor <ktraynor@redhat.com>,
Jiayu Hu <jiayu.hu@intel.com>,
dev@dpdk.org
Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, Gavin.Hu@arm.com,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation
Date: Thu, 27 Sep 2018 20:34:22 +0200 [thread overview]
Message-ID: <885a7cfc-7ac6-a4a5-f9ca-641eb6241e3d@redhat.com> (raw)
In-Reply-To: <16033cbd-ea29-bff8-3822-769b05642b93@redhat.com>
On 09/27/2018 08:05 PM, Kevin Traynor wrote:
> On 09/27/2018 01:37 PM, Maxime Coquelin wrote:
>>
>>
>> On 09/27/2018 02:24 PM, Maxime Coquelin wrote:
>>>
>>>
>>> On 09/17/2018 05:54 AM, Jiayu Hu wrote:
>>>> When perform enqueue operations on the split and packed ring,
>>> s/perform/performing/
>>> s/ring/rings/
>>>> if the reserved buffer length from the descriptor table execeeds
>>>> 65535, the returned length by fill_vec_buf_split/_packed() is
>>>> overflowed. This patch is to avoid this corner case.
>>> s/overflowed/overflows/
>>>>
>>>> Fixes: f689586b ("vhost: shadow used ring update")
>>>> Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path")
>>>> Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring")
>>>> Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings")
>>>> Fixes: a922401f ("vhost: add Rx support for packed ring")
>>>> Fixes: ae999ce4 ("vhost: add Tx support for packed ring")
>>>>
>
> It breaks the record for number of Fixes? :-)
This is exhaustive! :)
>
> I think relevant for stables also - any reason why not?
Forgot to mention, but I added it while applying.
FYI, it targets v18.08.
>>>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>>>> ---
>>>> lib/librte_vhost/virtio_net.c | 20 +++++++++++---------
>>>> 1 file changed, 11 insertions(+), 9 deletions(-)
>>>>
>>>
>>> Other than that, the patch looks good to me. Thanks for fixing it.
>>>
>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>
>>> Maxime
>>
>> Applied to dpdk-next-virtio/master with commit message fix.
>>
>> Thanks,
>> Maxime
>
prev parent reply other threads:[~2018-09-27 18:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1536305094-126439-1-git-send-email-jiayu.hu@intel.com>
[not found] ` <1537156482-46428-1-git-send-email-jiayu.hu@intel.com>
[not found] ` <47f35e9f-a211-5eb5-b2e9-23145f44d1bc@redhat.com>
[not found] ` <310219be-daa2-eb06-fc02-1e76784a01f4@redhat.com>
2018-09-27 18:05 ` Kevin Traynor
2018-09-27 18:34 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=885a7cfc-7ac6-a4a5-f9ca-641eb6241e3d@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Gavin.Hu@arm.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).