From: Olivier Matz <olivier.matz@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var
Date: Thu, 21 Jul 2016 15:28:10 +0200 [thread overview]
Message-ID: <887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com> (raw)
In-Reply-To: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com>
Hi Santosh,
On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> removing ptr var. Now freeing mp_stack var.
>
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
> app/test/test_mempool.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
> index 46ad670..3b21cf7 100644
> --- a/app/test/test_mempool.c
> +++ b/app/test/test_mempool.c
> @@ -506,7 +506,6 @@ test_mempool(void)
> {
> struct rte_mempool *mp_cache = NULL;
> struct rte_mempool *mp_nocache = NULL;
> - struct rte_mempool *mp_ext = NULL;
> struct rte_mempool *mp_stack = NULL;
>
> rte_atomic32_init(&synchro);
> @@ -605,7 +604,7 @@ test_mempool(void)
> err:
> rte_mempool_free(mp_nocache);
> rte_mempool_free(mp_cache);
> - rte_mempool_free(mp_ext);
> + rte_mempool_free(mp_stack);
> return -1;
> }
>
>
Strange, it seems these modifications were present in latest patch from
David Hunt (v6). Maybe a bad manipulation during the push?
The "Fixes:" line should be added though.
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2016-07-21 13:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 11:49 Santosh Shukla
2016-07-21 13:28 ` Olivier Matz [this message]
2016-07-21 13:35 ` Thomas Monjalon
2016-07-21 21:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).