From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens <jbehrens@vmware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6
Date: Tue, 24 May 2022 09:46:37 +0300 [thread overview]
Message-ID: <891f25c7-4145-9d34-7af3-bae8451cb5a5@oktetlabs.ru> (raw)
In-Reply-To: <BYAPR05MB56241564761B69BCFB381D82C9D49@BYAPR05MB5624.namprd05.prod.outlook.com>
Hi Pankai,
I'd consider a patch which adds RETA controls as well. IMHO it
is a major feature which could be interesting to end users.
Regards,
Andrew.
On 5/23/22 23:56, Pankaj Gupta wrote:
> Hi Andrew,
>
> New features were introduced in following two patches so I will update
> release_22_07.rst for these two patches.
>
> [PATCH v6 1/9] net/vmxnet3: add version 5 support
>
> [PATCH v6 6/9] net/vmxnet3: add version 6 support
>
> Let me know if I am missing anything.
>
> Thanks,
>
> Pankaj
>
> *From: *Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> *Date: *Thursday, May 19, 2022 at 1:07 AM
> *To: *Pankaj Gupta <pagupta@vmware.com>, Jochen Behrens
> <jbehrens@vmware.com>
> *Cc: *dev@dpdk.org <dev@dpdk.org>
> *Subject: *Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6
>
> ⚠External Email
>
> Hi Pankaj,
>
> I did final cleanup before applying the patch series, but
> realized that release notes update is missing.
> Please, pick up my changes and amend patches which support
> new features with release notes update in the documentation.
>
> Everything else LGTM now.
>
> Thanks,
> Andrew.
>
> On 5/19/22 11:04, Andrew Rybchenko wrote:
>> v6 (Andrew Rybchenko):
>> Minor style changes in patches description
>> Split FW version get patch to have callbacks reorder seperately
>> Minor fix in FW version get patch to put callback definition,
>> assignment and implementation just after device info get
>>
>> v5:
>> Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c
>> User RETA instead of reta in commit message
>> Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c
>>
>> v4:
>> Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error
>> in initialization for rxDataRing feature" to
>> "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")"
>>
>> v3:
>> adding Reviewed-by info in all the patches
>>
>> v2:
>> address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru
>>
>> Pankaj Gupta (9):
>> net/vmxnet3: add version 5 support
>> net/vmxnet3: implement RETA query and RETA update
>> net/vmxnet3: add Rx queue usage count utility
>> net/vmxnet3: fix ethdev callbacks init order
>> net/vmxnet3: report HW version on FW version get
>> net/vmxnet3: add version 6 support
>> net/vmxnet3: advertise RETA size in device info
>> net/vmxnet3: set packet type for fragmented packet
>> net/vmxnet3: fix merge error in Rx data ring initialization
>>
>> drivers/net/vmxnet3/base/vmxnet3_defs.h | 73 ++++-
>> drivers/net/vmxnet3/vmxnet3_ethdev.c | 339 +++++++++++++++++++-----
>> drivers/net/vmxnet3/vmxnet3_ethdev.h | 15 +-
>> drivers/net/vmxnet3/vmxnet3_rxtx.c | 49 +++-
>> 4 files changed, 388 insertions(+), 88 deletions(-)
>>
>
>
> ________________________________
>
> ⚠External Email: This email originated from outside of the organization.
> Do not click links or open attachments unless you recognize the sender.
>
next prev parent reply other threads:[~2022-05-24 6:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 4:22 [PATCH 0/8] vmxnet3 version V5 and V6 Pankaj Gupta
2022-05-03 4:22 ` [PATCH 1/8] vmxnet3: Added V5 support Pankaj Gupta
2022-05-03 4:22 ` [PATCH 2/8] vmxnet3: implement reta query and reta update Pankaj Gupta
2022-05-04 14:23 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 3/8] vmxnet3: add rx queue usage count utility Pankaj Gupta
2022-05-04 14:27 ` Andrew Rybchenko
2022-05-04 14:35 ` Morten Brørup
2022-05-04 17:58 ` Pankaj Gupta
2022-05-03 4:22 ` [PATCH 4/8] vmxnet3: add get hw version api Pankaj Gupta
2022-05-04 14:35 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 5/8] vmxnet3, version 6 Pankaj Gupta
2022-05-04 14:46 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 6/8] vmxnet3: set reta size Pankaj Gupta
2022-05-04 15:05 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 7/8] vmxnet3: Set packet for fragmented packet Pankaj Gupta
2022-05-04 15:07 ` Andrew Rybchenko
2022-05-04 20:40 ` Pankaj Gupta
2022-05-05 8:45 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature Pankaj Gupta
2022-05-04 15:09 ` Andrew Rybchenko
2022-05-04 20:37 ` Pankaj Gupta
2022-05-05 8:37 ` Andrew Rybchenko
2022-05-03 18:50 ` [PATCH 0/8] vmxnet3 version V5 and V6 Jochen Behrens
2022-05-04 14:28 ` Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 1/9] net/vmxnet3: add version 5 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 5/9] net/vmxnet3: report HW version on FW version get Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 6/9] net/vmxnet3: add version 6 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization Andrew Rybchenko
2022-05-19 8:07 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-23 20:56 ` Pankaj Gupta
2022-05-24 6:46 ` Andrew Rybchenko [this message]
2022-05-25 0:40 Pankaj Gupta
2022-05-31 13:40 ` Andrew Rybchenko
2022-05-31 13:41 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891f25c7-4145-9d34-7af3-bae8451cb5a5@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jbehrens@vmware.com \
--cc=pagupta@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).