From: wangyunjian <wangyunjian@huawei.com>
To: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
Huangshaozhang <huangshaozhang@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>,
lianglipei <lianglipei@huawei.com>
Subject: RE: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe
Date: Wed, 24 May 2023 07:11:30 +0000 [thread overview]
Message-ID: <898ab66ef3064add965d7811d9f7e791@huawei.com> (raw)
In-Reply-To: <CAJFAV8zotR=5EmFrVObKiTgroH7G-b+p7PgT_xDE56s1q1yNHQ@mail.gmail.com>
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Thursday, January 5, 2023 4:34 PM
> To: wangyunjian <wangyunjian@huawei.com>; Thomas Monjalon
> <thomas@monjalon.net>
> Cc: dev@dpdk.org; qi.z.zhang@intel.com; anatoly.burakov@intel.com;
> Huangshaozhang <huangshaozhang@huawei.com>; stable@dpdk.org;
> lianglipei <lianglipei@huawei.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe
>
> Hi Yunjian, Thomas,
>
> On Mon, Dec 5, 2022 at 9:02 AM Yunjian Wang <wangyunjian@huawei.com>
> wrote:
> >
> > In the device probing, there is no need to log the error message in
> > the case, that device has been already probed and return with -EEXIST.
> >
> > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Lipei Liang <lianglipei@huawei.com>
> > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>
> It seems it is a partial fix and a duplicate work for:
> https://patchwork.dpdk.org/project/dpdk/patch/20190302024253.15594-3-tho
> mas@monjalon.net/
I agree with Thomas's patch. Can we consider merging this patch first?
Because this err log can easily mislead problem troubleshooting.
>
> This patch is part of a series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=3612
> I see no activity on it, but there were some comments.
>
> Thomas, do you intend to work on this series of yours?
>
>
> --
> David Marchand
prev parent reply other threads:[~2023-05-24 7:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 8:02 Yunjian Wang
2023-01-05 8:34 ` David Marchand
2023-05-24 7:11 ` wangyunjian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=898ab66ef3064add965d7811d9f7e791@huawei.com \
--to=wangyunjian@huawei.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=huangshaozhang@huawei.com \
--cc=lianglipei@huawei.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).