From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>, <jerin.jacob@caviumnetworks.com>,
<santosh.shukla@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v3 3/7] mbuf: add pool ops name selection API helpers
Date: Fri, 19 Jan 2018 18:11:47 +0530 [thread overview]
Message-ID: <89a76d94-b4a1-7bf4-dd64-16096f8b6bbe@nxp.com> (raw)
In-Reply-To: <20180119100147.wbhddhtgcsbdac5w@platinum>
Hi Olivier,
On 1/19/2018 3:31 PM, Olivier Matz wrote:
> On Thu, Jan 18, 2018 at 06:56:28PM +0530, Hemant Agrawal wrote:
>> This patch add support for various mempool ops config helper APIs.
>>
>> 1.User defined mempool ops
>> 2.Platform detected HW mempool ops (active).
>> 3.Best selection of mempool ops by looking into user defined,
>> platform registered and compile time configured.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>
> ...
>
>> --- /dev/null
>> +++ b/lib/librte_mbuf/rte_mbuf_pool_ops.c
>> @@ -0,0 +1,68 @@
>> +/* SPDX-License-Identifier: BSD-3-Clause
>> + * Copyright 2018 NXP
>> + */
>> +
>> +#include <string.h>
>> +#include <rte_eal.h>
>> +#include <rte_mbuf.h>
>> +#include <rte_errno.h>
>> +#include <rte_mbuf_pool_ops.h>
>> +#include <rte_malloc.h>
>> +
>> +static char *plat_mbuf_pool_ops_name;
>
> I have some doubts about secondary processes.
>
> Maybe it's ok if the loaded driver and eal arguments are exactly the
> same in the secondary process. It would be safer to use a named memzone
> for that.
>
Typically a secondary process should not set the platform mempool name.
I can also add a check to know if secondary process is trying to do it.
Yes. I can change it to a named memzone.
> It would be even safer to not use secondary processes ;)
>
>
>> +
>> +int
>> +rte_mbuf_register_platform_mempool_ops(const char *ops_name)
>> +{
>
> We have "register" for platform and "set" for user.
> I think "set" should be used everywhere.
>
ok
>> + if (plat_mbuf_pool_ops_name == NULL) {
>> + plat_mbuf_pool_ops_name =
>> + rte_malloc(NULL, RTE_MEMPOOL_OPS_NAMESIZE, 0);
>> + if (plat_mbuf_pool_ops_name == NULL)
>> + return -ENOMEM;
>> + strcpy((char *)plat_mbuf_pool_ops_name, ops_name);
>
> If strlen(ops_name) >= RTE_MEMPOOL_OPS_NAMESIZE, this may lead to
> bad behavior.
>
That should not happen, we can check that.
> I suggest to simply do a strdup() instead.
Well, strdup based string will not be readable/accessible from the
secondary process?
>
>
>> + return 0;
>> + } else if (strcmp(plat_mbuf_pool_ops_name, ops_name) == 0) {
>> + return 0;
>> + }
>> +
>> + RTE_LOG(ERR, MBUF,
>> + "%s is already registered as platform mbuf pool ops\n",
>> + plat_mbuf_pool_ops_name);
>
> So, this log means that a we should try to never have 2 drivers registering
> different platform drivers on the same machine, right?
>
> So this API is kind of reserved for network processors and should not be
> used in usual PCI PMDs?
>
No, PCI PMDs can also use it. But only one registration allowed for now.
As I mentioned in the cover letter:
~~~~~
This logic can be further extended with addition for following
patch, which is still under discussion. The ethdev PMD capability exposed
through existing rte_eth_dev_pool_ops_supported() to select the update
the mempool ops with some "weight" based algorithm like:
http://dpdk.org/dev/patchwork/patch/32245/
~~~~~~
>
>> + return -EEXIST;
>> +}
>> +
>> +const char *
>> +rte_mbuf_platform_mempool_ops(void)
>> +{
>> + return (const char *)plat_mbuf_pool_ops_name;
>
> cast is not required
>
>> +}
>> +
>> +void
>> +rte_mbuf_set_user_mempool_ops(const char *ops_name)
>> +{
>> + rte_eal_set_mbuf_user_mempool_ops(ops_name);
>> +}
>
> Instead of calling the EAL API, we can set a static variable as
> for platform ops.
>
>> +
>> +const char *
>> +rte_mbuf_user_mempool_ops(void)
>> +{
>> + return rte_eal_mbuf_default_mempool_ops();
>> +}
>
> And here, I suggest instead:
>
> rte_mbuf_user_mempool_ops(void)
> {
> if (user_mbuf_pool_ops_name != NULL)
> return user_mbuf_pool_ops_name;
> return rte_eal_mbuf_default_mempool_ops();
> }
>
> i.e. rte_eal_mbuf_default_mempool_ops() remains the ops passed as
> command line arguments.
>
>
>> +
>> +/* Return mbuf pool ops name */
>> +const char *
>> +rte_mbuf_best_mempool_ops(void)
>> +{
>> + /* User defined mempool ops takes the priority */
>> + const char *best_ops = rte_mbuf_user_mempool_ops();
>> + if (best_ops)
>> + return best_ops;
>> +
>> + /* Next choice is platform configured mempool ops */
>> + best_ops = rte_mbuf_platform_mempool_ops();
>> + if (best_ops)
>> + return best_ops;
>> +
>> + /* Last choice is to use the compile time config pool */
>> + return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
>> +}
>
> I like this function, this is much clearer than what we have today :)
>
next prev parent reply other threads:[~2018-01-19 12:41 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 12:22 [dpdk-dev] [PATCH 0/2] Multiple Pktmbuf mempool support Hemant Agrawal
2017-07-04 12:22 ` [dpdk-dev] [PATCH 1/2] mempool: check the support for the given mempool Hemant Agrawal
2017-07-04 12:22 ` [dpdk-dev] [PATCH 2/2] mbuf: add support for preferred mempool list Hemant Agrawal
2017-09-22 7:13 ` [dpdk-dev] [PATCH 0/2] Multiple Pktmbuf mempool support Hemant Agrawal
2017-09-25 10:24 ` Olivier MATZ
2017-10-10 14:15 ` Thomas Monjalon
2017-10-10 14:21 ` Hemant Agrawal
2017-12-15 10:24 ` [dpdk-dev] [PATCH 0/2] Dynamic HW Mempool Detection Support Hemant Agrawal
2017-12-15 10:24 ` [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool Hemant Agrawal
2017-12-15 15:52 ` Stephen Hemminger
2017-12-18 9:26 ` Hemant Agrawal
2017-12-18 8:55 ` Jerin Jacob
2017-12-18 9:36 ` Hemant Agrawal
2017-12-22 14:59 ` Olivier MATZ
2017-12-28 12:07 ` Hemant Agrawal
2018-01-10 12:49 ` Hemant Agrawal
2017-12-22 14:41 ` Olivier MATZ
2017-12-15 10:24 ` [dpdk-dev] [PATCH 2/2] dpaa2: register dpaa2 mempool ops as active mempool Hemant Agrawal
2017-12-18 8:57 ` Jerin Jacob
2017-12-18 9:25 ` Hemant Agrawal
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 0/5] Dynamic HW Mempool Detection Support Hemant Agrawal
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 1/5] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 2/5] eal: add platform mempool ops name in internal config Hemant Agrawal
2018-01-15 12:24 ` Jerin Jacob
2018-01-15 14:31 ` Hemant Agrawal
2018-01-15 16:26 ` Jerin Jacob
2018-01-16 15:04 ` Olivier Matz
2018-01-16 15:08 ` Jerin Jacob
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 3/5] mbuf: support register mempool Hw ops name APIs Hemant Agrawal
2018-01-15 11:41 ` Jerin Jacob
2018-01-15 14:24 ` Hemant Agrawal
2018-01-15 14:37 ` Jerin Jacob
2018-01-15 12:36 ` Jerin Jacob
2018-01-16 15:09 ` Olivier Matz
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 4/5] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-15 12:31 ` Jerin Jacob
2018-01-15 14:32 ` Hemant Agrawal
2018-01-15 6:11 ` [dpdk-dev] [PATCH v2 5/5] mbuf: add user command line config mempools ops API Hemant Agrawal
2018-01-15 12:29 ` Jerin Jacob
2018-01-15 14:35 ` Hemant Agrawal
2018-01-15 16:23 ` Jerin Jacob
2018-01-16 15:01 ` [dpdk-dev] [PATCH v2 0/5] Dynamic HW Mempool Detection Support Olivier Matz
2018-01-18 11:47 ` Hemant Agrawal
2018-01-18 13:42 ` Olivier Matz
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 0/7] " Hemant Agrawal
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 1/7] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-19 10:01 ` Olivier Matz
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 2/7] eal: add API to set user default mbuf mempool ops Hemant Agrawal
2018-01-19 10:01 ` Olivier Matz
2018-01-19 12:31 ` Hemant Agrawal
2018-01-19 12:43 ` Olivier Matz
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 3/7] mbuf: add pool ops name selection API helpers Hemant Agrawal
2018-01-19 10:01 ` Olivier Matz
2018-01-19 12:41 ` Hemant Agrawal [this message]
2018-01-19 13:10 ` Olivier Matz
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 4/7] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 5/7] app/testpmd: set preferred mempool as default pktpool Hemant Agrawal
2018-01-19 10:01 ` Olivier Matz
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 6/7] dpaa2: register dpaa2 as platform HW mempool on runtime Hemant Agrawal
2018-01-18 13:26 ` [dpdk-dev] [PATCH v3 7/7] dpaa: register dpaa " Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 0/7] Dynamic HW Mempool Detection Support Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 1/7] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 2/7] mbuf: maintain user and compile time mempool ops name Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 3/7] mbuf: add pool ops name selection API helpers Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 4/7] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 5/7] app/testpmd: set preferred mempool as default pktpool Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 6/7] dpaa: register dpaa as platform HW mempool on runtime Hemant Agrawal
2018-01-19 16:33 ` [dpdk-dev] [PATCH v4 7/7] dpaa2: register dpaa2 " Hemant Agrawal
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 0/7] Dynamic HW Mempool Detection Support Hemant Agrawal
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 1/7] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-22 13:23 ` Olivier Matz
2018-01-22 13:24 ` Hemant Agrawal
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 2/7] mbuf: maintain user and compile time mempool ops name Hemant Agrawal
2018-01-22 13:23 ` Olivier Matz
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 3/7] mbuf: add pool ops name selection API helpers Hemant Agrawal
2018-01-22 13:23 ` Olivier Matz
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 4/7] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-22 13:24 ` Olivier Matz
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 5/7] app/testpmd: set preferred mempool as default pktpool Hemant Agrawal
2018-01-22 13:25 ` Olivier Matz
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 6/7] dpaa: register dpaa as platform HW mempool on runtime Hemant Agrawal
2018-01-20 6:15 ` [dpdk-dev] [PATCH v5 7/7] dpaa2: register dpaa2 " Hemant Agrawal
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 0/7] Dynamic HW Mempool Detection Support Hemant Agrawal
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 1/7] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-22 14:43 ` santosh
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 2/7] mbuf: maintain user and compile time mempool ops name Hemant Agrawal
2018-01-22 14:47 ` santosh
2018-01-25 22:02 ` Thomas Monjalon
2018-01-26 5:10 ` Hemant Agrawal
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 3/7] mbuf: add pool ops name selection API helpers Hemant Agrawal
2018-01-22 14:49 ` santosh
2018-01-25 22:01 ` Thomas Monjalon
2018-01-26 5:10 ` Hemant Agrawal
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 4/7] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-22 14:51 ` santosh
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 5/7] app/testpmd: set preferred mempool as default pktpool Hemant Agrawal
2018-01-22 14:52 ` santosh
2018-01-25 22:04 ` Thomas Monjalon
2018-01-26 5:11 ` Hemant Agrawal
2018-01-26 7:43 ` Thomas Monjalon
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 6/7] dpaa: register dpaa as platform HW mempool on runtime Hemant Agrawal
2018-01-22 13:51 ` [dpdk-dev] [PATCH v6 7/7] dpaa2: register dpaa2 " Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 0/7] Dynamic HW Mempool Detection Support Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 1/7] eal: prefix mbuf pool ops name with user defined Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 2/7] mbuf: maintain user and compile time mempool ops name Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 3/7] mbuf: add pool ops name selection API helpers Hemant Agrawal
2018-01-29 8:44 ` Andrew Rybchenko
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 4/7] mbuf: pktmbuf pool create helper for specific mempool ops Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 5/7] app/testpmd: add debug to print preferred " Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 6/7] dpaa: register dpaa as platform HW mempool on runtime Hemant Agrawal
2018-01-29 8:10 ` [dpdk-dev] [PATCH v7 7/7] dpaa2: register dpaa2 " Hemant Agrawal
2018-01-29 18:03 ` [dpdk-dev] [PATCH v7 0/7] Dynamic HW Mempool Detection Support Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a76d94-b4a1-7bf4-dd64-16096f8b6bbe@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).