From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>, konstantin.ananyev@intel.com
Cc: wenzhuo.lu@intel.com, helin.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: enable PTYPE offload for x86 vector PMD
Date: Mon, 12 Jun 2017 11:18:28 +0100 [thread overview]
Message-ID: <89bdca5f-e6b1-b756-45be-3ea47b7c0d28@intel.com> (raw)
In-Reply-To: <1497158256-10059-1-git-send-email-qi.z.zhang@intel.com>
On 6/11/2017 6:17 AM, Qi Zhang wrote:
> Hardware PTYPE in Rx desc will be parsed to fill
> mbuf's packet_type.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
<...>
> diff --git a/drivers/net/ixgbe/Makefile b/drivers/net/ixgbe/Makefile
> index 5529d81..8b86fe3 100644
> --- a/drivers/net/ixgbe/Makefile
> +++ b/drivers/net/ixgbe/Makefile
> @@ -125,6 +125,11 @@ SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += ixgbe_82599_bypass.c
> endif
> SRCS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += rte_pmd_ixgbe.c
>
> +# vector PMD driver needs SSE4.1 support
> +ifeq ($(findstring RTE_MACHINE_CPUFLAG_SSE4_1,$(CFLAGS)),)
> +CFLAGS_ixgbe_rxtx_vec_sse.o += -msse4.1
> +endif
Hi Qi,
What happens if runtime doesn't have SSE4.1 support?
Should we add a dynamic check as done in 140e [1] ?
And I am for extracting this part into another patch, to highlight what
is done here.
patch 1: Increase ixgbe minimum required support to SSE4.1
Patch 2: Add PTYPE support to vector PMD
[1]
http://dpdk.org/browse/dpdk/tree/drivers/net/i40e/i40e_rxtx_vec_sse.c#n626
> +
> # install this header file
> SYMLINK-$(CONFIG_RTE_LIBRTE_IXGBE_PMD)-include := rte_pmd_ixgbe.h
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 2083cde..3e39648 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3717,6 +3717,14 @@ ixgbe_dev_supported_ptypes_get(struct rte_eth_dev *dev)
> dev->rx_pkt_burst == ixgbe_recv_pkts_lro_bulk_alloc ||
> dev->rx_pkt_burst == ixgbe_recv_pkts_bulk_alloc)
> return ptypes;
> +
> +#if defined(RTE_ARCH_X86_64) || \
> + defined(RTE_ARCH_X86_X32) || \
> + defined(RTE_ARCH_I686)
It is possible to use single "RTE_ARCH_X86" here, to cover all three.
> + if (dev->rx_pkt_burst == ixgbe_recv_pkts_vec ||
> + dev->rx_pkt_burst == ixgbe_recv_scattered_pkts_vec)
> + return ptypes;
> +#endif
> return NULL;
> }
<...>
next prev parent reply other threads:[~2017-06-12 10:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1494991243-21940-1-git-send-email-qi.z.zhang@intel.com>
2017-06-11 5:17 ` Qi Zhang
2017-06-11 14:40 ` Ananyev, Konstantin
2017-06-12 10:18 ` Ferruh Yigit [this message]
2017-06-12 12:27 ` Zhang, Qi Z
2017-06-13 8:58 ` [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD's minimum requirement Qi Zhang
2017-06-13 8:58 ` [dpdk-dev] [PATCH v4 2/2] net/ixgbe: enable PTYPE offload for x86 vector PMD Qi Zhang
2017-07-07 11:00 ` Ferruh Yigit
2017-06-13 16:30 ` [dpdk-dev] [PATCH v4 1/2] net/ixgbe: add SSE4.1 support to vPMD's minimum requirement Richardson, Bruce
2017-06-13 17:22 ` Ananyev, Konstantin
2017-06-15 10:26 ` Ferruh Yigit
2017-07-07 10:57 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89bdca5f-e6b1-b756-45be-3ea47b7c0d28@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).