From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Anoob Joseph <anoobj@marvell.com>
Cc: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"David Marchand" <david.marchand@redhat.com>,
"jerinj@marvell.com" <jerinj@marvell.com>, nd <nd@arm.com>,
"Pavan Nikhilesh Bhagavatula" <pbhagavatula@marvell.com>,
"Ruifeng Wang" <Ruifeng.Wang@arm.com>,
"Wathsala Wathawana Vithanage" <wathsala.vithanage@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v2] config/arm: add Marvell Odyssey
Date: Wed, 6 Mar 2024 05:00:02 +0000 [thread overview]
Message-ID: <8BAD9A53-06A6-46AD-9780-70FCAE8FC32F@arm.com> (raw)
In-Reply-To: <PH0PR18MB467271448DB518391234B485DF212@PH0PR18MB4672.namprd18.prod.outlook.com>
> On Mar 5, 2024, at 10:41 PM, Anoob Joseph <anoobj@marvell.com> wrote:
>
> Hi Honnappa,
>
> Thanks for the review. Please see inline.
>
> Thanks,
> Anoob
>
>> -----Original Message-----
>> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Sent: Wednesday, March 6, 2024 8:50 AM
>> To: Anoob Joseph <anoobj@marvell.com>
>> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; thomas@monjalon.net; David
>> Marchand <david.marchand@redhat.com>; Jerin Jacob <jerinj@marvell.com>; nd
>> <nd@arm.com>; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
>> Ruifeng Wang <Ruifeng.Wang@arm.com>; Wathsala Wathawana Vithanage
>> <wathsala.vithanage@arm.com>; dev@dpdk.org
>> Subject: [EXTERNAL] Re: [PATCH v2] config/arm: add Marvell Odyssey
>>
>> Prioritize security for external emails: Confirm sender and content safety before
>> clicking links or opening attachments
>>
>> ----------------------------------------------------------------------
>>
>>
>>> On Mar 5, 2024, at 5:13 AM, Anoob Joseph <anoobj@marvell.com> wrote:
>>>
>>> Add meson build configuration for Marvell Odyssey platform with 64-bit
>>> ARM Neoverse V2 cores.
>>>
>>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>>> ---
>>>
>>> Depends-on: series-31141 ("config/arm: add Neoverse V2 part number")
>>>
>>> Changes in v2:
>>> - Renamed config file
>>>
>>> config/arm/arm64_odyssey_linux_gcc | 17 +++++++++++++++++
>>> config/arm/meson.build | 15 +++++++++++++++
>>> 2 files changed, 32 insertions(+)
>>> create mode 100644 config/arm/arm64_odyssey_linux_gcc
>>>
>>> diff --git a/config/arm/arm64_odyssey_linux_gcc
>>> b/config/arm/arm64_odyssey_linux_gcc
>>> new file mode 100644
>>> index 0000000000..69b5cd42d8
>>> --- /dev/null
>>> +++ b/config/arm/arm64_odyssey_linux_gcc
>>> @@ -0,0 +1,17 @@
>>> +[binaries]
>>> +c = ['ccache', 'aarch64-marvell-linux-gnu-gcc'] cpp = ['ccache',
>>> +'aarch64-marvell-linux-gnu-g++'] ar =
>>> +'aarch64-marvell-linux-gnu-gcc-ar'
>>> +strip = 'aarch64-marvell-linux-gnu-strip'
>>> +pkgconfig = 'aarch64-linux-gnu-pkg-config'
>>> +
>>> +[host_machine]
>>> +system = 'linux'
>>> +cpu_family = 'aarch64'
>>> +cpu = 'armv9-a'
>>> +endian = 'little'
>>> +
>>> +[properties]
>>> +platform = 'odyssey'
>>> +
>>> +[built-in options]
>>
>> Just thinking out loud, given that this is a 80 core V2 machine, do we need cross
>> compilation support? I have the same question for Grace machine as well. I am
>> thinking we should have cross compilation support only for embedded platforms.
>
> [Anoob] DPDK binaries may not be built natively in all cases. When there are standard release packages with pre-built binaries, it would help in having cross compilation.
Ack
>
>>
>>
>>> diff --git a/config/arm/meson.build b/config/arm/meson.build index
>>> 3886d0e2dc..94159efaa4 100644
>>> --- a/config/arm/meson.build
>>> +++ b/config/arm/meson.build
>>> @@ -500,6 +500,20 @@ soc_n2 = {
>>> 'numa': false
>>> }
>>>
>>> +soc_odyssey = {
>>> + 'description' : 'Marvell Odyssey',
>>> + 'implementer' : '0x41',
>>> + 'flags': [
>>> + ['RTE_MAX_LCORE', 80],
>>> + ['RTE_MAX_NUMA_NODES', 1],
>>> + ['RTE_MEMPOOL_ALIGN', 128],
>>> + ],
>>> + 'part_number': '0xd4f',
>>> + 'extra_march_features': ['crypto'],
>>> + 'numa': false,
>>> + 'sve_acle': false
>>> +}
>>> +
>> Can you move it such that it is sorted alphabetically?
>
> [Anoob] soc_cn9k portion is not following alphabetical order. I think it is so because of the renaming from soc_octeontx2 to soc_cn9k. I can push a separate patch to have this addressed. New addition in this patch is following alphabetical order. soc_odyssey is added between n2 & stingray.
Yes, please push a separate patch for cn9k.
>
>>
>>> soc_cn9k = {
>>> 'description': 'Marvell OCTEON 9',
>>> 'implementer': '0x43',
>>> @@ -617,6 +631,7 @@ socs = {
>>> 'kunpeng930': soc_kunpeng930,
>>> 'n1sdp': soc_n1sdp,
>>> 'n2': soc_n2,
>>> + 'odyssey' : soc_odyssey,
>>> 'stingray': soc_stingray,
>>> 'thunderx2': soc_thunderx2,
>>> 'thunderxt88': soc_thunderxt88,
>>> --
>>> 2.25.1
>>>
>
next prev parent reply other threads:[~2024-03-06 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 10:17 [PATCH] " Anoob Joseph
2024-03-05 11:13 ` [PATCH v2] " Anoob Joseph
2024-03-06 2:37 ` Ruifeng Wang
2024-03-06 3:19 ` Honnappa Nagarahalli
2024-03-06 4:41 ` Anoob Joseph
2024-03-06 5:00 ` Honnappa Nagarahalli [this message]
2024-03-06 5:03 ` Honnappa Nagarahalli
2024-03-06 5:50 ` [PATCH v3] " Anoob Joseph
2024-03-06 15:42 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8BAD9A53-06A6-46AD-9780-70FCAE8FC32F@arm.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=anoobj@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).