From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 21/28] librte_ether: remove branches on pci_dev
Date: Thu, 29 Oct 2015 14:32:29 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219F758D9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20151029115141.GA10272@bricha3-MOBL3>
Hi Bruce,
<snip>
> > /* attach the new physical device, then store port_id of the device
> > */ @@ -1143,14 +1141,11 @@ rte_eth_dev_configure(uint8_t port_id,
> uint16_t nb_rx_q, uint16_t nb_tx_q,
> > * If link state interrupt is enabled, check that the
> > * device supports it.
> > */
> > - if (dev_conf->intr_conf.lsc == 1) {
> > - const struct rte_pci_driver *pci_drv = &dev->driver-
> >pci_drv;
> > -
> > - if (!(pci_drv->drv_flags & RTE_PCI_DRV_INTR_LSC)) {
> > + if ((dev_conf->intr_conf.lsc == 1) &&
> > + (!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC))) {
> > PMD_DEBUG_TRACE("driver %s does not support
> lsc\n",
> > - pci_drv->name);
> > + dev->data->drv_name);
>
> Is this safe to do? From your previous patches for the vdevs, you appear to
> be setting the drv_name field to NULL for those vdevs, leading to undefined
> behaviour here. (printf may catch the NULL and print it as "(null)" rather than
> crashing, but it's still wrong!)
>
> /Bruce
It would be safer to set dev->data->drv_name to the PMD driver name.
Regards,
Bernard.
next prev parent reply other threads:[~2015-10-29 14:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PATCH v5>
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 00/28] remove pci driver from vdevs Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 01/28] librte_eal: add RTE_KDRV_NONE for vdevs Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 03/28] librte_ether: add function rte_eth_copy_dev_info Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 04/28] ixgbe: copy pci device info to eth_dev data Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 05/28] e1000: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 06/28] i40e: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 07/28] fm10k: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 08/28] bnx2x: " Bernard Iremonger
2015-10-23 22:37 ` Harish Patil
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 09/28] cxgbe: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 10/28] enic: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 11/28] mlx4: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 12/28] virtio: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 13/28] vmxnet3: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 14/28] null: copy " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 15/28] ring: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 16/28] pcap: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 17/28] af_packet: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 18/28] xenvirt: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 19/28] mpipe: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 20/28] bonding: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 21/28] librte_ether: remove branches on pci_dev Bernard Iremonger
2015-10-29 11:51 ` Bruce Richardson
2015-10-29 14:32 ` Iremonger, Bernard [this message]
2015-10-29 14:35 ` Bruce Richardson
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 22/28] null: remove pci device Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 23/28] ring: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 24/28] pcap: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 25/28] af_packet: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 26/28] xenvirt: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 27/28] mpipe: " Bernard Iremonger
2015-10-23 17:36 ` [dpdk-dev] [PATCH v5 28/28] bonding: " Bernard Iremonger
2015-10-29 12:18 ` [dpdk-dev] [PATCH v5 00/28] remove pci driver from vdevs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C219F758D9@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).