From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: reduce number of hugepages needed
Date: Thu, 10 Dec 2015 13:26:14 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219F8ED41@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20151210125911.GV29571@yliu-dev.sh.intel.com>
Hi Yuanhan,
<snip>
> > /*-
> > * BSD LICENSE
> > *
> > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> > * All rights reserved.
> > *
> > * Redistribution and use in source and binary forms, with or without
> > @@ -53,7 +53,8 @@
> >
> > #include "main.h"
> >
> > -#define MAX_QUEUES 512
> > +/* decrease MAX_QUEUES from 512 to reduce number of hugepages
> needed
> > +*/
>
> Minor nit: I would suggest to simply remove this comment, which might be a
> bit confusing without the content (that 512 would let vhost-switch fail to start
> if given memory is small).
>
> Otherwise, this patch looks good to me.
>
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
>
> Thanks.
>
> --yliu
>
<snip>
I will remove the comment.
Can I keep your ack.
Regards,
Bernard.
next prev parent reply other threads:[~2015-12-10 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 12:19 Bernard Iremonger
2015-12-10 12:59 ` Yuanhan Liu
2015-12-10 13:26 ` Iremonger, Bernard [this message]
2015-12-10 13:34 ` Yuanhan Liu
2015-12-10 13:53 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2015-12-10 14:50 ` Ananyev, Konstantin
2015-12-10 15:43 ` Iremonger, Bernard
2015-12-11 9:05 ` Panu Matilainen
2015-12-10 15:49 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2015-12-10 16:32 ` Ananyev, Konstantin
2015-12-10 21:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C219F8ED41@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).