From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Eric Kinzie <ehkinzie@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine
Date: Thu, 25 Feb 2016 15:22:35 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C219FB4852@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <56CB0709.6010407@redhat.com>
Hi Eric,
<snip>
> > @@ -157,6 +159,7 @@ struct rte_eth_bond_8023ad_conf {
> > uint32_t tx_period_ms;
> > uint32_t rx_marker_period_ms;
> > uint32_t update_timeout_ms;
> > + rte_eth_bond_8023ad_ext_slowrx_fn slowrx_cb;
> > };
>
> This still is a likely an ABI break, previously discussed around here:
> http://dpdk.org/ml/archives/dev/2015-November/027321.html
>
> It might not be embedded anywhere in DPDK codebase, but there's no
> telling what others might have done with it (have an array of them, embed in
> other structs etc).
>
> Also ultimately ABI compatibility goes both ways: when the library soname
> does not change then an application is free to assume both downgrading and
> upgrading are safe. In this case, upgrading *might* be okay, downgrading
> certainly is not. So by that measure it definitely is an ABI break.
>
> [...]
> > diff --git a/drivers/net/bonding/rte_eth_bond_version.map
> > b/drivers/net/bonding/rte_eth_bond_version.map
> > index 22bd920..33d73ff 100644
> > --- a/drivers/net/bonding/rte_eth_bond_version.map
> > +++ b/drivers/net/bonding/rte_eth_bond_version.map
> > @@ -27,3 +27,9 @@ DPDK_2.1 {
> > rte_eth_bond_free;
> >
> > } DPDK_2.0;
> > +
> > +DPDK_2.2 {
> > + rte_eth_bond_8023ad_ext_collect;
> > + rte_eth_bond_8023ad_ext_distrib;
> > + rte_eth_bond_8023ad_ext_slowtx;
> > +} DPDK_2.1;
> >
>
> These symbols are not part of DPDK 2.2, the version here is wrong.
> Technically it would not actually matter much but better not to confuse
> things unnecessarily.
>
> - Panu -
It looks like Panu's points are valid, a V3 of this patch set which takes care of these issues will be needed.
Patches 1/6, 5/6 and 6/6 of the patch set are bug fixes, so each patch should contain a fixes line.
Patches 2/6, 3/6 and 4/6 are a new feature, the release notes should be updated for this feature.
Could I suggest splitting the patch set into two patch sets, a bug fix patch set and a new feature patch set.
Regards,
Bernard.
next prev parent reply other threads:[~2016-02-25 15:22 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 17:14 [dpdk-dev] [PATCH 0/8] bonding: fixes and enhancements Stephen Hemminger
2015-12-04 17:14 ` [dpdk-dev] [PATCH 1/8] bond: use existing enslaved device queues Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 2/8] bond mode 4: copy entire config structure Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 3/8] bond mode 4: do not ignore multicast Stephen Hemminger
2016-01-05 13:32 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 4/8] bond mode 4: allow external state machine Stephen Hemminger
2016-01-05 13:33 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 5/8] bond: active slaves with no primary Stephen Hemminger
2016-01-05 13:34 ` Declan Doherty
2015-12-04 17:14 ` [dpdk-dev] [PATCH 6/8] bond: handle slaves with fewer queues than bonding device Stephen Hemminger
2015-12-04 18:36 ` Andriy Berestovskyy
2015-12-04 19:18 ` Eric Kinzie
2016-01-05 13:46 ` Declan Doherty
2016-01-05 15:31 ` Stephen Hemminger
2016-02-03 11:28 ` Bruce Richardson
2016-02-03 15:17 ` Declan Doherty
2016-02-03 15:21 ` Thomas Monjalon
2016-02-18 10:26 ` Iremonger, Bernard
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 0/6] bonding: fixes and enhancements Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 1/6] bond: use existing enslaved device queues Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 2/6] bond mode 4: copy entire config structure Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 3/6] bond mode 4: do not ignore multicast Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine Eric Kinzie
2016-02-22 13:03 ` Panu Matilainen
2016-02-25 15:22 ` Iremonger, Bernard [this message]
2016-03-01 17:31 ` [dpdk-dev] [PATCH V3 0/4] bonding: fixes and enhancements Eric Kinzie
2016-03-01 17:31 ` [dpdk-dev] [PATCH V3 1/4] bond mode 4: copy entire config structure Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 2/4] bond mode 4: do not ignore multicast Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 3/4] bond: active slaves with no primary Eric Kinzie
2016-03-01 17:32 ` [dpdk-dev] [PATCH V3 4/4] bond: do not activate slave twice Eric Kinzie
2016-03-10 15:41 ` [dpdk-dev] [PATCH V3 0/4] bonding: fixes and enhancements Bruce Richardson
2016-03-01 17:40 ` [dpdk-dev] [PATCH v2 4/6] bond mode 4: allow external state machine Eric Kinzie
2016-03-02 9:49 ` Iremonger, Bernard
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 5/6] bond: active slaves with no primary Eric Kinzie
2016-02-19 19:17 ` [dpdk-dev] [PATCH v2 6/6] bond: do not activate slave twice Eric Kinzie
2015-12-04 17:14 ` [dpdk-dev] [PATCH 7/8] bond: per-slave intermediate rx ring Stephen Hemminger
2015-12-04 17:14 ` [dpdk-dev] [PATCH 8/8] bond: do not activate slave twice Stephen Hemminger
2016-01-05 13:47 ` Declan Doherty
2015-12-23 10:51 ` [dpdk-dev] [PATCH 0/8] bonding: fixes and enhancements Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C219FB4852@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ehkinzie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).