From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display
Date: Tue, 14 Jun 2016 14:14:17 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C21A0394D5@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C9608B6@IRSMSX108.ger.corp.intel.com>
Hi Pablo,
<snip>
> > Subject: [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from
> > fwd_config_display
> >
> > Add call to fwd_config_setup to init_config.
> > Remove fwd_config_setup from fwd_config_display.
> > Add call to fwd_config_setup for corelist, coremask and nbcore setup.
> > Add call to fwd_config_setup for portlist, portmask and nbport setup.
> > Add call to fwd_config_setup for rxq, txq, rxd and txd setup.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
> Apologies for misleading here, but I think we should drop this patch for the
> moment.
> It is conflicting with another patch and it is not really necessary for your
> changes (am I right here?), so I would say best thing to do is to drop it and
> discuss if we want this change separately.
This patch is needed for the patchset and should not be dropped.
Is it conflicting with patch the following patch?
http://dpdk.org/dev/patchwork/patch/13132/
This patch is renaming fwd_config_display to fwd_config_setup_display.
It clarifies what the function is doing, but does not address the issue of separating the setup from the display.
Separating the setup from the display is resolved in my patch.
Regards,
Bernard.
next prev parent reply other threads:[~2016-06-14 14:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 12:52 [dpdk-dev] [PATCH 0/4] testpmd forwarding Bernard Iremonger
2016-04-20 12:52 ` [dpdk-dev] [PATCH 1/4] testpmd: add function port_is_forwarding Bernard Iremonger
2016-04-20 12:52 ` [dpdk-dev] [PATCH 2/4] testpmd: don't update fwding config when attaching/detaching a port Bernard Iremonger
2016-04-20 12:52 ` [dpdk-dev] [PATCH 3/4] testpmd: check port is not forwarding in stop_port and close_port Bernard Iremonger
2016-04-20 12:52 ` [dpdk-dev] [PATCH 4/4] testpmd: reconfigure forwarding after changing portlist Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 0/8] app/testpmd: forwarding Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 1/8] app/testpmd: add function port_is_forwarding Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 2/8] app/testpmd: don't update fwding config when attaching/detaching a port Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 3/8] app/testpmd: check port is not forwarding in stop_port and close_port Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 4/8] app/testpmd: reconfigure forwarding after changing portlist Bernard Iremonger
2016-06-08 14:17 ` De Lara Guarch, Pablo
2016-06-10 9:22 ` Iremonger, Bernard
2016-06-10 15:58 ` Iremonger, Bernard
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 5/8] app/testpmd: add function port_is_bonding_slave Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 6/8] app/testpmd: move call to init_fwd_streams Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 7/8] app/testpmd: check for valid socket id when attaching port Bernard Iremonger
2016-05-05 15:39 ` [dpdk-dev] [PATCH v2 8/8] app/testpmd: check for valid mbuf pool Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 0/9] app/testpmd: forwarding Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 1/9] app/testpmd: add function port_is_forwarding Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 2/9] app/testpmd: don't update fwding config when attaching/detaching a port Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 3/9] app/testpmd: check port is not forwarding in stop_port and close_port Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display Bernard Iremonger
2016-06-13 15:57 ` De Lara Guarch, Pablo
2016-06-13 16:07 ` Iremonger, Bernard
2016-06-14 9:18 ` Iremonger, Bernard
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 5/9] app/testpmd: add function port_is_bonding_slave Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 6/9] app/testpmd: move call to init_fwd_streams Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 7/9] app/testpmd: check for valid socket id when attaching port Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 8/9] app/testpmd: check for valid mbuf pool Bernard Iremonger
2016-06-12 15:23 ` [dpdk-dev] [PATCH v3 9/9] app/testpmd: stop forwarding on exit Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 0/9] app/testpmd: forwarding Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 1/9] app/testpmd: add function port_is_forwarding Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 2/9] app/testpmd: don't update fwding config when attaching/detaching a port Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 3/9] app/testpmd: check port is not forwarding in stop_port and close_port Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 4/9] app/testpmd: remove fwd_config_setup from fwd_config_display Bernard Iremonger
2016-06-14 13:00 ` De Lara Guarch, Pablo
2016-06-14 14:14 ` Iremonger, Bernard [this message]
2016-06-14 14:30 ` De Lara Guarch, Pablo
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 5/9] app/testpmd: add function port_is_bonding_slave Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 6/9] app/testpmd: move call to init_fwd_streams Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 7/9] app/testpmd: check for valid socket id when attaching port Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 8/9] app/testpmd: check for valid mbuf pool Bernard Iremonger
2016-06-14 12:28 ` [dpdk-dev] [PATCH v4 9/9] app/testpmd: stop forwarding on exit Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 0/9] app/testpmd: forwarding Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 1/9] app/testpmd: add new function Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 2/9] app/testpmd: do not update forwarding config Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 3/9] app/testpmd: check port is not forwarding Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 4/9] app/testpmd: separate fwd config setup from display Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 5/9] app/testpmd: add another new function Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 6/9] app/testpmd: move fwd streams initialisation Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 7/9] app/testpmd: check for valid socket id when attaching port Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 8/9] app/testpmd: check for valid mbuf pool Bernard Iremonger
2016-06-14 15:35 ` [dpdk-dev] [PATCH v5 9/9] app/testpmd: stop forwarding on exit Bernard Iremonger
2016-06-14 15:39 ` [dpdk-dev] [PATCH v5 0/9] app/testpmd: forwarding De Lara Guarch, Pablo
2016-06-16 8:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C21A0394D5@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).