From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] doc: announce API and ABI change for ethdev
Date: Thu, 5 Jan 2017 14:40:54 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D1AF44@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3085992.4K2P9mV14s@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, January 5, 2017 1:31 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] doc: announce API and ABI change for
> ethdev
>
> 2017-01-05 10:44, Bernard Iremonger:
> > In 17.05 nine rte_eth_dev_* functions will be removed from
> > librte_ether, renamed and moved to the ixgbe PMD.
>
> I agree it is a good move to clean up ethdev API.
>
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* ethdev: for 17.05 it is planned to deprecate the following nine
> > +rte_eth_dev_* functions
> > + and move them into the ixgbe PMD:
> > +
> > + ``rte_eth_dev_bypass_init``
> > +
> > + ``rte_eth_dev_bypass_state_set``
> > +
> > + ``rte_eth_dev_bypass_state_show``
> > +
> > + ``rte_eth_dev_bypass_event_store``
> > +
> > + ``rte_eth_dev_bypass_event_show``
> > +
> > + ``rte_eth_dev_wd_timeout_store``
> > +
> > + ``rte_eth_dev_bypass_wd_timeout_show``
> > +
> > + ``rte_eth_dev_bypass_ver_show``
> > +
> > + ``rte_eth_dev_bypass_wd_reset``
> > +
> > + The following fields will be removed from ``struct eth_dev_ops``:
> > +
> > + ``bypass_init_t``
> > +
> > + ``bypass_state_set_t``
> > +
> > + ``bypass_state_show_t``
> > +
> > + ``bypass_event_set_t``
> > +
> > + ``bypass_event_show_t``
> > +
> > + ``bypass_wd_timeout_set_t``
> > +
> > + ``bypass_wd_timeout_show_t``
> > +
> > + ``bypass_ver_show_t``
> > +
> > + ``bypass_wd_reset_t``
> > +
> > + The functions will be renamed to the following, and moved to the
> ``ixgbe`` PMD:
> > +
> > + ``rte_pmd_ixgbe_bypass_init``
> > +
> > + ``rte_pmd_ixgbe_bypass_state_set``
> > +
> > + ``rte_pmd_ixgbe_bypass_state_show``
> > +
> > + ``rte_pmd_ixgbe_bypass_event_set``
> > +
> > + ``rte_pmd_ixgbe_bypass_event_show``
> > +
> > + ``rte_pmd_ixgbe_bypass_wd_timeout_set``
> > +
> > + ``rte_pmd_ixgbe_bypass_wd_timeout_show``
> > +
> > + ``rte_pmd_ixgbe_bypass_ver_show``
> > +
> > + ``rte_pmd_ixgbe_bypass_wd_reset``
> >
>
> Please could you make it shorter by using commas for listing?
I will use commas for the listing in v2.
Regards,
Bernard.
next prev parent reply other threads:[~2017-01-05 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 10:44 Bernard Iremonger
2017-01-05 13:31 ` Thomas Monjalon
2017-01-05 14:40 ` Iremonger, Bernard [this message]
2017-01-05 15:25 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2017-02-13 17:57 ` Thomas Monjalon
2017-02-14 3:17 ` Jerin Jacob
2017-02-14 10:33 ` Iremonger, Bernard
2017-02-14 19:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D1AF44@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).