From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close
Date: Fri, 6 Jan 2017 12:00:05 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D1B4CF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810CC3E79@SHSMSX103.ccr.corp.intel.com>
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, January 6, 2017 1:29 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in
> close
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> > Sent: Tuesday, January 3, 2017 2:55 PM
> > To: dev@dpdk.org
> > Cc: Iremonger, Bernard <bernard.iremonger@intel.com>;
> stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault
> > in close
> >
> > From: Bernard Iremonger <bernard.iremonger@intel.com>
> >
> > The vsi's have already been released, so the second call to
> > i40e_vsi_release results in a segmentation fault.
> > The second call to i40e_vsi_release has been removed.
> Where is the first call to release vmdq vsi?
All of the VSI's are released in the call to i40e_vsi_release(pf->main_vsi) at line 1895.
This function is recursive and release all the VSI's.
There is still a VSI address in pf->vmdq[i].vsi but calling
i40e_vsi_release(pf->vmdq[i].vsi);
Results in a segmentation fault.
>
> Thanks
> Jingjing
> >
> > Fixes: 3cb446b4aeb2 ("i40e: free vmdq vsi when closing")
> >
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index be45cfa..0b7c366 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -1882,7 +1882,6 @@ static inline void i40e_GLQF_reg_init(struct
> > i40e_hw
> > *hw)
> > i40e_vsi_release(pf->main_vsi);
> >
> > for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {
> > - i40e_vsi_release(pf->vmdq[i].vsi);
> > pf->vmdq[i].vsi = NULL;
> > }
> >
> > @@ -4137,6 +4136,9 @@ enum i40e_status_code
> > if (!vsi)
> > return I40E_SUCCESS;
> >
> > + if (!vsi->adapter)
> > + return I40E_ERR_BAD_PTR;
> > +
> > user_param = vsi->user_param;
> >
> > pf = I40E_VSI_TO_PF(vsi);
> > --
> > 1.9.3
Regards,
Bernard.
next prev parent reply other threads:[~2017-01-06 12:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
[not found] ` <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
2016-12-07 3:31 ` [dpdk-stable] [PATCH v2 11/32] net/i40e: fix VF reset flow Wenzhuo Lu
2016-12-07 3:31 ` [dpdk-stable] [PATCH v2 14/32] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1482302070-128496-1-git-send-email-wenzhuo.lu@intel.com>
2016-12-21 6:34 ` [dpdk-stable] [PATCH v6 09/25] net/i40e: fix VF reset flow Wenzhuo Lu
2016-12-21 6:34 ` [dpdk-stable] [PATCH v6 12/25] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1483426488-117332-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-03 6:54 ` [dpdk-stable] [PATCH v7 09/27] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-03 6:54 ` [dpdk-stable] [PATCH v7 12/27] net/i40e: fix VF MAC address assignment Wenzhuo Lu
2017-01-03 6:54 ` [dpdk-stable] [PATCH v7 26/27] net/i40e: fix segmentation fault in close Wenzhuo Lu
2017-01-06 1:29 ` [dpdk-stable] [dpdk-dev] " Wu, Jingjing
2017-01-06 12:00 ` Iremonger, Bernard [this message]
2017-01-09 9:44 ` Wu, Jingjing
2017-01-09 9:50 ` Iremonger, Bernard
[not found] ` <1484032580-60134-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-10 7:16 ` [dpdk-stable] [PATCH v8 09/25] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-10 7:16 ` [dpdk-stable] [PATCH v8 12/25] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1484290401-1404-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-13 6:53 ` [dpdk-stable] [PATCH v9 09/26] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-13 6:53 ` [dpdk-stable] [PATCH v9 12/26] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1484545911-40432-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-16 5:51 ` [dpdk-stable] [PATCH v10 09/26] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-16 5:51 ` [dpdk-stable] [PATCH v10 12/26] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1484620116-70813-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-17 2:28 ` [dpdk-stable] [PATCH v11 09/26] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-17 2:28 ` [dpdk-stable] [PATCH v11 12/26] net/i40e: fix VF MAC address assignment Wenzhuo Lu
[not found] ` <1484642728-73411-1-git-send-email-wenzhuo.lu@intel.com>
2017-01-17 8:45 ` [dpdk-stable] [PATCH v12 09/26] net/i40e: fix VF reset flow Wenzhuo Lu
2017-01-17 8:45 ` [dpdk-stable] [PATCH v12 12/26] net/i40e: fix VF MAC address assignment Wenzhuo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D1B4CF@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).