From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Helin" <helin.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 1/2] net/i40e: fix segmentation fault in close
Date: Tue, 17 Jan 2017 16:30:23 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D1F3E9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810CCA2B6@SHSMSX103.ccr.corp.intel.com>
Hi Jingjing,
<snip>
> > Subject: [PATCH v3 1/2] net/i40e: fix segmentation fault in close
> >
> > Change the order of releasing the vsi's.
> > Release the vmdq vsi's first, then release the main vsi.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> >
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index f13e61b..e8cfec8 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -2068,18 +2068,17 @@ i40e_dev_close(struct rte_eth_dev *dev)
> > /* shutdown and destroy the HMC */
> > i40e_shutdown_lan_hmc(hw);
> >
> > - /* release all the existing VSIs and VEBs */
> > - i40e_fdir_teardown(pf);
> > - i40e_vsi_release(pf->main_vsi);
> > -
> > for (i = 0; i < pf->nb_cfg_vmdq_vsi; i++) {
> > i40e_vsi_release(pf->vmdq[i].vsi);
> > pf->vmdq[i].vsi = NULL;
> > }
> > -
> > rte_free(pf->vmdq);
> > pf->vmdq = NULL;
> >
> > + /* release all the existing VSIs and VEBs */
> > + i40e_fdir_teardown(pf);
> > + i40e_vsi_release(pf->main_vsi);
> > +
> > /* shutdown the adminq */
> > i40e_aq_queue_shutdown(hw, true);
> > i40e_shutdown_adminq(hw);
> > @@ -4342,6 +4341,9 @@ i40e_vsi_release(struct i40e_vsi *vsi)
> > if (!vsi)
> > return I40E_SUCCESS;
> >
> > + if (!vsi->adapter)
> > + return I40E_ERR_BAD_PTR;
> > +
>
> The change looks fine to me.
> Only minor comments like:
> The dev_close is ethdev level ops, I40E_XX error code need to be replaced
> by The error code defined in ethedev level.
I will replace I40E_ERR_BAD_PTR with -EFAULT in v4.
Regards,
Bernard.
prev parent reply other threads:[~2017-01-17 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1483979366-16914-1-git-send-email-bernard.iremonger@intel.com>
2017-01-09 16:29 ` [dpdk-stable] [PATCH v2 " Bernard Iremonger
2017-01-12 13:58 ` [dpdk-stable] [PATCH v3 " Bernard Iremonger
2017-01-17 14:34 ` Wu, Jingjing
2017-01-17 16:30 ` Iremonger, Bernard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D1F3E9@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).