From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter
Date: Fri, 31 Mar 2017 17:05:28 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D4E128@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1ebd9937-1027-b25c-b5af-4c97312bf835@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, March 31, 2017 5:53 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
> Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v6 0/5] net/i40e: QinQ filter
>
> On 3/31/2017 4:18 PM, Bernard Iremonger wrote:
> > It adds support for QinQ filters.
> > It uses the replace filter Admin Queue command.
> >
> > Changes in v6:
> > Rebase to latest dpdk-next-net.
> > Fix checkpatch warnings.
> >
> > Changes in v5:
> > Rebase to latest dpdk-next-net.
> > Rebase patches 2 and 3 following comments.
> > Uses map_5.88 firmware.
> >
> > Changes in v4:
> > Reordered patches following comments.
> > Revises patches 2 and 3 following comments.
> >
> > Changes in v3:
> > Rebase to latest dpdk-next-net.
> > Revised patches 1-3 following comments.
> > Added patches 4 and 5.
> >
> > Changes in v2:
> > Rebase to latest dpdk-next-net.
> > Reordered patches, and reduced from 4 to 3 patches.
> >
> > Bernard Iremonger (5):
> > net/i40e: initialise L3 MAP register
> > net/i40e: add QinQ filter create function
> > net/i40e: parse QinQ pattern
> > net/i40e: update destroy tunnel filter function
> > net/i40e: update tunnel filter restore function
>
> Still getting some long-line checkpatch warnings [1], can you please check
> them?
>
> Thanks,
> ferruh
>
> [1]
> WARNING:LONG_LINE: line over 80 characters
> #46: FILE: drivers/net/i40e/i40e_ethdev.c:1136:
> + ret = i40e_aq_debug_write_register(hw, I40E_GLQF_L3_MAP(40),
> 0x00000028, NULL);
>
> WARNING:LONG_LINE: line over 80 characters
> #144: FILE: drivers/net/i40e/i40e_ethdev.c:12363:
> + filter_replace.old_filter_type =
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_STAG_IVLAN;
>
> WARNING:LONG_LINE: line over 80 characters
> #150: FILE: drivers/net/i40e/i40e_ethdev.c:12369:
> + filter_replace_buf.data[0] |=
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED;
>
> WARNING:LONG_LINE: line over 80 characters
> #154: FILE: drivers/net/i40e/i40e_ethdev.c:12373:
> + filter_replace_buf.data[4] =
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_FV_INNER_VLAN;
>
> WARNING:LONG_LINE: line over 80 characters
> #155: FILE: drivers/net/i40e/i40e_ethdev.c:12374:
> + filter_replace_buf.data[4] |=
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED;
>
> WARNING:LONG_LINE: line over 80 characters
> #159: FILE: drivers/net/i40e/i40e_ethdev.c:12378:
> + ret = i40e_aq_replace_cloud_filters(hw, &filter_replace,
> &filter_replace_buf);
>
> WARNING:LONG_LINE: line over 80 characters
> #176: FILE: drivers/net/i40e/i40e_ethdev.c:12395:
> + filter_replace_buf.data[0] |=
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED;
>
> WARNING:LONG_LINE: line over 80 characters
> #178: FILE: drivers/net/i40e/i40e_ethdev.c:12397:
> + filter_replace_buf.data[4] |=
> I40E_AQC_REPLACE_CLOUD_CMD_INPUT_VALIDATED;
>
> WARNING:LONG_LINE: line over 80 characters
> #179: FILE: drivers/net/i40e/i40e_ethdev.c:12398:
> + ret = i40e_aq_replace_cloud_filters(hw, &filter_replace,
> &filter_replace_buf);
The checkpatch script is allowing lines up to 90 characters now.
Previously long lines were acceptable .
Regards,
Bernard.
next prev parent reply other threads:[~2017-03-31 17:05 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 14:48 [dpdk-dev] [PATCH v1 0/4] " Bernard Iremonger
2017-03-03 14:48 ` [dpdk-dev] [PATCH v1 1/4] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-03 14:48 ` [dpdk-dev] [PATCH v1 2/4] net/i40e: add QinQ wrapper function Bernard Iremonger
2017-03-03 14:48 ` [dpdk-dev] [PATCH v1 3/4] net/i40e: changes to consistent filter set Bernard Iremonger
2017-03-03 14:48 ` [dpdk-dev] [PATCH v1 4/4] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-23 16:38 ` [dpdk-dev] [PATCH v2 0/3] net/i40e: QinQ filter Bernard Iremonger
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 0/5] " Bernard Iremonger
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 " Bernard Iremonger
2017-03-30 16:01 ` Bernard Iremonger
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2017-03-31 13:33 ` Ferruh Yigit
2017-03-31 13:37 ` Iremonger, Bernard
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 " Bernard Iremonger
2017-03-31 16:53 ` Ferruh Yigit
2017-03-31 17:05 ` Iremonger, Bernard [this message]
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 " Bernard Iremonger
2017-04-03 9:24 ` Ferruh Yigit
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 1/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 2/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 3/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 4/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-31 17:58 ` [dpdk-dev] [PATCH v7 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 1/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 2/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 3/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 4/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-31 15:18 ` [dpdk-dev] [PATCH v6 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 1/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 2/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-31 9:43 ` Xing, Beilei
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 3/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-31 0:58 ` Lu, Wenzhuo
2017-03-31 8:01 ` Iremonger, Bernard
2017-03-31 8:27 ` Lu, Wenzhuo
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 4/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-30 16:09 ` [dpdk-dev] [PATCH v5 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-30 16:01 ` [dpdk-dev] [PATCH v4 1/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-30 16:01 ` [dpdk-dev] [PATCH v4 2/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-30 16:01 ` [dpdk-dev] [PATCH v4 3/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-30 16:01 ` [dpdk-dev] [PATCH v4 4/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-30 16:01 ` [dpdk-dev] [PATCH v4 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 1/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-30 0:54 ` Lu, Wenzhuo
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 2/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-30 0:57 ` Lu, Wenzhuo
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 3/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 4/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-29 16:41 ` [dpdk-dev] [PATCH v4 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 1/5] net/i40e: add QinQ filter create function Bernard Iremonger
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 2/5] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-29 1:25 ` Lu, Wenzhuo
2017-03-29 15:10 ` Iremonger, Bernard
2017-03-29 2:46 ` Xing, Beilei
2017-03-29 6:16 ` Xing, Beilei
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 3/5] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 4/5] net/i40e: initialise L3 MAP register Bernard Iremonger
2017-03-29 1:24 ` Xing, Beilei
2017-03-29 8:27 ` Iremonger, Bernard
2017-03-29 1:53 ` Lu, Wenzhuo
2017-03-29 8:56 ` Iremonger, Bernard
2017-03-28 16:20 ` [dpdk-dev] [PATCH v3 5/5] net/i40e: update tunnel filter restore function Bernard Iremonger
2017-03-29 1:54 ` Lu, Wenzhuo
2017-03-23 16:38 ` [dpdk-dev] [PATCH v2 1/3] net/i40e: add QinQ wrapper function Bernard Iremonger
2017-03-28 8:11 ` Lu, Wenzhuo
2017-03-28 11:09 ` Iremonger, Bernard
2017-03-28 13:23 ` Iremonger, Bernard
2017-03-29 0:52 ` Lu, Wenzhuo
2017-03-29 9:11 ` Iremonger, Bernard
2017-03-23 16:38 ` [dpdk-dev] [PATCH v2 2/3] net/i40e: parse QinQ pattern Bernard Iremonger
2017-03-28 8:45 ` Lu, Wenzhuo
2017-03-28 11:12 ` Iremonger, Bernard
2017-03-23 16:38 ` [dpdk-dev] [PATCH v2 3/3] net/i40e: update destroy tunnel filter function Bernard Iremonger
2017-03-28 8:54 ` Lu, Wenzhuo
2017-03-28 11:13 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D4E128@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).