DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API
Date: Thu, 15 Jun 2017 10:56:22 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E018162@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <15933671.otTXsCeEv9@xps>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, June 14, 2017 10:22 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API
> 
> Hi,
> 
> 12/06/2017 17:18, Bernard Iremonger:
> > Change the rte_eth_dev_callback_process function to return int, and
> > add a void *ret_param parameter.
> 
> You should squash tests and examples changes in this change to avoid
> breaking compilation.
> Doc patch can also be squashed.
> 

I will squash patches into one patch.

> > --- a/lib/librte_ether/rte_ether_version.map
> > +++ b/lib/librte_ether/rte_ether_version.map
> > +DPDK_17.08 {
> > +	global:
> > +
> > +	_rte_eth_dev_callback_process;
> > +
> > +} DPDK_17.05;
> 
> You should remove the original function from 2.2 ABI block.

I will remove from 2.2 ABI block.

Thanks for the review.

Regards,

Bernard.

next prev parent reply	other threads:[~2017-06-15 10:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-19 11:03 [dpdk-dev] [PATCH v1 0/4] ethdev: " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 1/4] ethdev: modify " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 2/4] test: callback process API changes Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 3/4] examples: " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 4/4] doc: remove deprecation notice Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 0/4] ethdev: callback process API Bernard Iremonger
2017-06-15 12:29   ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2017-06-15 12:29   ` [dpdk-dev] [PATCH v3] ethdev: modify " Bernard Iremonger
2017-07-01 15:19     ` Thomas Monjalon
2017-07-03  9:01       ` Ferruh Yigit
2017-07-03  9:04         ` Ferruh Yigit
2017-07-03 11:06           ` Iremonger, Bernard
2017-07-03 11:18             ` Ferruh Yigit
2017-07-03 11:28               ` Iremonger, Bernard
2017-07-03 11:40                 ` Thomas Monjalon
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 1/4] " Bernard Iremonger
2017-06-14 21:22   ` Thomas Monjalon
2017-06-15 10:56     ` Iremonger, Bernard [this message]
2017-06-15 15:43   ` Stephen Hemminger
2017-06-21  9:22     ` Iremonger, Bernard
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 2/4] test: callback process API changes Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 3/4] examples: " Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 4/4] doc: remove deprecation notice Bernard Iremonger
2017-06-13  8:52   ` Mcnamara, John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C24E018162@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).