From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Shrikrishna Khare <skhare@vmware.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API
Date: Mon, 3 Jul 2017 11:28:47 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E01D672@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <2d48d57d-ffb2-5767-7fcd-35d6f43f9420@intel.com>
Hi Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, July 3, 2017 12:19 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Shrikrishna Khare
> <skhare@vmware.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process API
>
> On 7/3/2017 12:06 PM, Iremonger, Bernard wrote:
> > Hi Ferruh,
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Monday, July 3, 2017 10:05 AM
> >> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Shrikrishna
> >> Khare <skhare@vmware.com>
> >> Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: modify callback process
> >> API
> >>
> >> On 7/3/2017 10:01 AM, Ferruh Yigit wrote:
> >>> On 7/1/2017 4:19 PM, Thomas Monjalon wrote:
> >>>> 15/06/2017 14:29, Bernard Iremonger:
> >>>>> From: "Bernard.Iremonger" <Bernard.iremonger@intel.com>
> >>>>>
> >>>>> Change the rte_eth_dev_callback_process function to return int,
> >>>>> and add a void *ret_param parameter.
> >>>>
> >>>> Adding this explanation:
> >>>> The new parameter is used by ixgbe and i40e instead of abusing
> >>>> the user data of the callback.
> >>>> and this title:
> >>>> ethdev: add return values to callback process API
> >>>>
> >>>> And applied, thanks
> >>>>
> >>>
> >>> Hi Bernard, Shrikrishna,
> >>>
> >>> This patch breaks vmxnet3 build, can you please send a patch to fix it?
> >>
> >> The build error is on next-net. Main repo looks good.
> >>
> >>>
> >>> Thanks,
> >>> ferruh
> >>>
> >
> > In dpdk-next-net a call to _rte_eth_dev_callback_process() has been
> added in vmxnet3_ethdev.c at line 1321 using the old API.
> > I can send a patch or could you add an extra NULL parameter at line 1325 in
> vmxnet3_ethdev.c?
>
> Fix is trivial, but I shouldn't just update the code. It should be done by a
> proper process, with a fix patch.
>
> Would you mind sending the patch?
>
> Thanks,
> ferruh
>
> >
> > Regards,
> >
> > Bernard.
> >
I can send the patch, however I am seeing the following build error on the dpdk and dpdk-next-net at present:
CC eal_interrupts.o
/root/dpdk_sforge_origin/lib/librte_eal/linuxapp/eal/eal_memory.c:58:18: fatal error: numa.h: No such file or directory
#include <numa.h>
^
compilation terminated.
Are you seeing this error?
Regards,
Bernard.
next prev parent reply other threads:[~2017-07-03 11:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 11:03 [dpdk-dev] [PATCH v1 0/4] ethdev: " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 1/4] ethdev: modify " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 2/4] test: callback process API changes Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 3/4] examples: " Bernard Iremonger
2017-05-19 11:03 ` [dpdk-dev] [PATCH v1 4/4] doc: remove deprecation notice Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 0/4] ethdev: callback process API Bernard Iremonger
2017-06-15 12:29 ` [dpdk-dev] [PATCH v3] " Bernard Iremonger
2017-06-15 12:29 ` [dpdk-dev] [PATCH v3] ethdev: modify " Bernard Iremonger
2017-07-01 15:19 ` Thomas Monjalon
2017-07-03 9:01 ` Ferruh Yigit
2017-07-03 9:04 ` Ferruh Yigit
2017-07-03 11:06 ` Iremonger, Bernard
2017-07-03 11:18 ` Ferruh Yigit
2017-07-03 11:28 ` Iremonger, Bernard [this message]
2017-07-03 11:40 ` Thomas Monjalon
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 1/4] " Bernard Iremonger
2017-06-14 21:22 ` Thomas Monjalon
2017-06-15 10:56 ` Iremonger, Bernard
2017-06-15 15:43 ` Stephen Hemminger
2017-06-21 9:22 ` Iremonger, Bernard
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 2/4] test: callback process API changes Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 3/4] examples: " Bernard Iremonger
2017-06-12 15:18 ` [dpdk-dev] [PATCH v2 4/4] doc: remove deprecation notice Bernard Iremonger
2017-06-13 8:52 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E01D672@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=skhare@vmware.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).