From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide
Date: Thu, 2 Nov 2017 17:29:24 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E05A913@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EDEFE0C@IRSMSX103.ger.corp.intel.com>
Hi John,
<snip>
> > Subject: [PATCH 1/2] doc: flow classify library prog guide
> >
> > This file documents the Flow Classification library, librte_flow_classify.
> >
> > Updated MAINTAINERS file
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
> Hi Bernard,
>
> Thanks for the doc.
>
> There is a doc build warning due to a reference to a file that is in the 2/2
> patch:
>
> $ make doc-guides-html -j
> sphinx processing guides-html...
> /work/dpdk_docs/doc/guides/prog_guide/flow_classify_lib.rst:64:
> WARNING: unknown document: ../sample_app_ug/flow_classify
>
Both docs reference each other.
I could squash the patches into one, or add a third patch with the reference.
Which option would you prefer?
>
> There are also 2 x s/classifer/classifier/ typos in this patch and 1 in 2/2.
I will fix typo's
>
> John
>
>
Thanks for the review.
Regards,
Bernard.
next prev parent reply other threads:[~2017-11-02 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 9:09 [dpdk-dev] [PATCH 0/2] flow classify documentation Bernard Iremonger
2017-10-26 9:09 ` [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide Bernard Iremonger
2017-11-02 16:58 ` Mcnamara, John
2017-11-02 17:29 ` Iremonger, Bernard [this message]
2017-11-03 9:52 ` Mcnamara, John
2017-11-03 15:32 ` Iremonger, Bernard
2017-10-26 9:09 ` [dpdk-dev] [PATCH 2/2] doc: flow classify sample app guide Bernard Iremonger
2017-11-02 17:00 ` Mcnamara, John
2017-11-02 17:32 ` Iremonger, Bernard
2017-11-03 11:13 ` [dpdk-dev] [PATCH v2] flow classify documentation Bernard Iremonger
2017-11-03 11:13 ` [dpdk-dev] [PATCH v2] doc: flow classify guides Bernard Iremonger
2017-11-03 15:34 ` Mcnamara, John
2017-11-07 22:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E05A913@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).