From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] examples/flow_classify: update sample application
Date: Thu, 14 Dec 2017 14:42:32 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C24E068E73@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20171211162646.146936-3-jasvinder.singh@intel.com>
Hi Jasvinder,
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Monday, December 11, 2017 4:27 PM
> To: dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: [PATCH v2 3/4] examples/flow_classify: update sample application
>
> Update the flow_classify sample app to adapt the changes.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> v2:
> - use validate api to verify before adding flow rule
>
> examples/flow_classify/flow_classify.c | 36 +++++++++++++++++++++++--------
> ---
> 1 file changed, 25 insertions(+), 11 deletions(-)
>
> diff --git a/examples/flow_classify/flow_classify.c
> b/examples/flow_classify/flow_classify.c
> index 766f1dd..25b8fc6 100644
> --- a/examples/flow_classify/flow_classify.c
> +++ b/examples/flow_classify/flow_classify.c
> @@ -94,7 +94,6 @@ static const struct rte_eth_conf port_conf_default = {
>
> struct flow_classifier {
> struct rte_flow_classifier *cls;
> - uint32_t table_id[RTE_FLOW_CLASSIFY_TABLE_MAX];
> };
>
> struct flow_classifier_acl {
> @@ -195,7 +194,15 @@ static struct rte_flow_item end_item = {
> RTE_FLOW_ITEM_TYPE_END,
> /* sample actions:
> * "actions count / end"
> */
> -static struct rte_flow_action count_action = {
> RTE_FLOW_ACTION_TYPE_COUNT, 0};
> +struct rte_flow_query_count count = {
> + .reset = 1,
> + .hits_set = 1,
> + .bytes_set = 1,
> + .hits = 0,
> + .bytes = 0,
> +};
> +static struct rte_flow_action count_action = {
> RTE_FLOW_ACTION_TYPE_COUNT,
> + &count};
> static struct rte_flow_action end_action = { RTE_FLOW_ACTION_TYPE_END, 0};
> static struct rte_flow_action actions[2];
>
> @@ -274,7 +281,7 @@ lcore_main(struct flow_classifier *cls_app)
> int i = 0;
>
> ret = rte_flow_classify_table_entry_delete(cls_app->cls,
> - cls_app->table_id[0], rules[7]);
> + rules[7]);
> if (ret)
> printf("table_entry_delete failed [7] %d\n\n", ret);
> else
> @@ -317,7 +324,6 @@ lcore_main(struct flow_classifier *cls_app)
> if (rules[i]) {
> ret = rte_flow_classifier_query(
> cls_app->cls,
> - cls_app->table_id[0],
> bufs, nb_rx, rules[i],
> &classify_stats);
> if (ret)
> @@ -634,9 +640,18 @@ add_classify_rule(struct rte_eth_ntuple_filter
> *ntuple_filter,
> actions[0] = count_action;
> actions[1] = end_action;
>
> + /* Validate and add rule */
> + ret = rte_flow_classify_validate(cls_app->cls, &attr,
> + pattern_ipv4_5tuple, actions);
Parameter &error is missing from validate call, resulting in a compile error.
> + if (ret) {
> + printf("table entry validate failed ipv4_proto = %u\n",
> + ipv4_proto);
> + return ret;
> + }
> +
> rule = rte_flow_classify_table_entry_add(
> - cls_app->cls, cls_app->table_id[0], &key_found,
> - &attr, pattern_ipv4_5tuple, actions, &error);
> + cls_app->cls, &attr, pattern_ipv4_5tuple,
> + actions, &key_found, &error);
> if (rule == NULL) {
> printf("table entry add failed ipv4_proto = %u\n",
> ipv4_proto);
> @@ -809,7 +824,6 @@ main(int argc, char *argv[])
>
> cls_params.name = "flow_classifier";
> cls_params.socket_id = socket_id;
> - cls_params.type = RTE_FLOW_CLASSIFY_TABLE_TYPE_ACL;
>
> cls_app->cls = rte_flow_classifier_create(&cls_params);
> if (cls_app->cls == NULL) {
> @@ -824,11 +838,11 @@ main(int argc, char *argv[])
> memcpy(table_acl_params.field_format, ipv4_defs, sizeof(ipv4_defs));
>
> /* initialise table create params */
> - cls_table_params.ops = &rte_table_acl_ops,
> - cls_table_params.arg_create = &table_acl_params,
> + cls_table_params.ops = &rte_table_acl_ops;
> + cls_table_params.arg_create = &table_acl_params;
> + cls_table_params.type =
> RTE_FLOW_CLASSIFY_TABLE_ACL_IP4_5TUPLE;
>
> - ret = rte_flow_classify_table_create(cls_app->cls, &cls_table_params,
> - &cls_app->table_id[0]);
> + ret = rte_flow_classify_table_create(cls_app->cls, &cls_table_params);
> if (ret) {
> rte_flow_classifier_free(cls_app->cls);
> rte_free(cls_app);
> --
> 2.9.3
next prev parent reply other threads:[~2017-12-14 14:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 11:32 [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id parameter from apis Jasvinder Singh
2017-11-23 11:32 ` [dpdk-dev] [PATCH 2/3] lib/librte_flow_classy: add run api for flow classification Jasvinder Singh
2017-12-04 16:46 ` Iremonger, Bernard
2017-12-05 11:01 ` Iremonger, Bernard
2017-12-06 12:41 ` Iremonger, Bernard
2017-12-11 15:52 ` Singh, Jasvinder
2017-11-23 11:32 ` [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib Jasvinder Singh
2017-12-06 12:04 ` Iremonger, Bernard
2017-12-11 14:54 ` Mcnamara, John
2017-12-11 15:53 ` Singh, Jasvinder
2017-12-04 16:45 ` [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id parameter from apis Iremonger, Bernard
2017-12-05 10:59 ` Iremonger, Bernard
2017-12-06 12:34 ` Iremonger, Bernard
2017-12-11 15:51 ` Singh, Jasvinder
2017-12-11 16:26 ` [dpdk-dev] [PATCH v2 1/4] " Jasvinder Singh
2017-12-11 16:26 ` [dpdk-dev] [PATCH v2 2/4] test/test_flow_classify: update test to accomodate changes Jasvinder Singh
2017-12-11 16:26 ` [dpdk-dev] [PATCH v2 3/4] examples/flow_classify: update sample application Jasvinder Singh
2017-12-14 14:42 ` Iremonger, Bernard [this message]
2017-12-11 16:26 ` [dpdk-dev] [PATCH v2 4/4] doc: update documentation for flow classify lib Jasvinder Singh
2017-12-14 14:49 ` Iremonger, Bernard
2017-12-15 10:39 ` [dpdk-dev] [PATCH v3 1/4] lib/librte_flow_classify: remove table id parameter from apis Jasvinder Singh
2017-12-15 10:39 ` [dpdk-dev] [PATCH v3 2/4] test/test_flow_classify: update test to accommodate changes Jasvinder Singh
2017-12-19 12:06 ` Iremonger, Bernard
2017-12-15 10:39 ` [dpdk-dev] [PATCH v3 3/4] examples/flow_classify: update sample application Jasvinder Singh
2017-12-19 12:09 ` Iremonger, Bernard
2017-12-15 10:39 ` [dpdk-dev] [PATCH v3 4/4] doc: update documentation for flow classify lib Jasvinder Singh
2017-12-18 11:04 ` Kovacevic, Marko
2017-12-18 13:40 ` Singh, Jasvinder
2017-12-19 12:13 ` Iremonger, Bernard
2017-12-19 12:03 ` [dpdk-dev] [PATCH v3 1/4] lib/librte_flow_classify: remove table id parameter from apis Iremonger, Bernard
2017-12-19 14:29 ` [dpdk-dev] [PATCH v4 " Jasvinder Singh
2017-12-19 14:29 ` [dpdk-dev] [PATCH v4 2/4] test/test_flow_classify: update test to accommodate changes Jasvinder Singh
2017-12-19 14:29 ` [dpdk-dev] [PATCH v4 3/4] examples/flow_classify: update sample application Jasvinder Singh
2017-12-19 14:29 ` [dpdk-dev] [PATCH v4 4/4] doc: update documentation for flow classify lib Jasvinder Singh
2018-01-10 0:19 ` [dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis Thomas Monjalon
2018-01-10 9:54 ` Singh, Jasvinder
2018-01-10 10:52 ` Thomas Monjalon
2018-01-10 10:59 ` Singh, Jasvinder
2018-01-10 11:07 ` Thomas Monjalon
2018-01-10 11:12 ` Singh, Jasvinder
2018-01-11 18:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C24E068E73@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).