From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx address and port
Date: Thu, 14 Jun 2018 10:17:46 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260CB347E@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20180611182526.32327-2-stephen@networkplumber.org>
Hi Stephen,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Monday, June 11, 2018 7:25 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Stephen
> Hemminger <sthemmin@microsoft.com>
> Subject: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx address
> and port
>
> Change the IP address and UDP port used for testpmd Tx only test. The old
> values overlap common NAT local networks; instead use reserved addresses
> in IETF RFC 2544.
The commit message should probably refer to RFC 863 too.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> app/test-pmd/txonly.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
> 1f08b6ed37a2..a24000e3af44 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -40,11 +40,13 @@
>
> #include "testpmd.h"
>
> -#define UDP_SRC_PORT 1024
> -#define UDP_DST_PORT 1024
> +/* RFC863 discard port */
> +#define UDP_SRC_PORT 9
> +#define UDP_DST_PORT 9
>
> -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define
> IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
> +/* RFC2544 reserved test subnet 192.18.0.0 */ #define IP_SRC_ADDR
> +((192U << 24) | (18 << 16) | (0 << 8) | 1) #define IP_DST_ADDR ((192U
> +<< 24) | (18 << 16) | (0 << 8) | 2)
>
> #define IP_DEFTTL 64 /* from RFC 1340. */
> #define IP_VERSION 0x40
> --
> 2.17.1
dpdk/devtools/check-git-log.sh is showing the following error
Wrong headline label:
testpmd: use RFC values for Tx address and port
It should be app/testpmd
Regards,
Bernard.
next prev parent reply other threads:[~2018-06-14 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 18:25 [dpdk-dev] [PATCH v2 0/2] testpmd: allow configure of Tx IP parameters Stephen Hemminger
2018-06-11 18:25 ` [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx address and port Stephen Hemminger
2018-06-14 10:17 ` Iremonger, Bernard [this message]
2018-06-14 15:56 ` Stephen Hemminger
2018-06-11 18:25 ` [dpdk-dev] [PATCH v2 2/2] testpmd: add ability to set tx IP and UDP parameters Stephen Hemminger
2018-06-14 10:30 ` Iremonger, Bernard
2018-06-18 19:31 ` Stephen Hemminger
2018-06-18 19:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260CB347E@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).