From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "ailan@redhat.com" <ailan@redhat.com>,
"jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
"vkaplans@redhat.com" <vkaplans@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Jens Freimann <jfreimann@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour
Date: Fri, 29 Jun 2018 14:05:12 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <195bb20b-441a-571e-8925-6db0a8af56c2@redhat.com>
Hi Maxime, Thomas,
<snip>
> Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy
> neighbour
>
> Hi Bernard,
>
> On 06/26/2018 01:09 PM, Iremonger, Bernard wrote:
> > checkpatch.pl is showing the following warnings:
> >
> > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> > #122: FILE: app/test-pmd/noisy_vnf.c:1:
> > +/* SPDX-License-Identifier: BSD-3-Clause
>
> I'm not sure to get what is wrong here, any thoughts?
>
I have looked at code and compared it with other license headers and it looks ok to me.
Hi Thomas,
Could you take a look please to see if you can spot something.
> <snip/>
>
> > WARNING: line over 80 characters
> > #394: FILE: app/test-pmd/parameters.c:1154:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-buffersize-before-sending")) {
> >
> > WARNING: line over 80 characters
> > #402: FILE: app/test-pmd/parameters.c:1162:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-flush-timeout")) {
> >
> > WARNING: line over 80 characters
> > #410: FILE: app/test-pmd/parameters.c:1170:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-memory-footprint")) {
> >
> > WARNING: line over 80 characters
> > #413: FILE: app/test-pmd/parameters.c:1173:
> > + noisy_vnf_memory_footprint =
> > + (uint16_t) n;
> >
> > WARNING: line over 80 characters
> > #418: FILE: app/test-pmd/parameters.c:1178:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-nb-rnd-write")) {
> >
> > WARNING: line over 80 characters
> > #426: FILE: app/test-pmd/parameters.c:1186:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-nb-rnd-read")) {
> >
> > WARNING: line over 80 characters
> > #434: FILE: app/test-pmd/parameters.c:1194:
> > + if (!strcmp(lgopts[opt_idx].name,
> > + "noisy-nb-rnd-read-write")) {
>
> The above ones were left intentionally for consistency with code around them.
>
> Should I fix them? (I'm fine doing it if you prefer)
I have looked at the code and I think it would be better to fix them.
The existing code has much shorter strings.
There is some flexibility around the line length, but it depends on the tree maintainer.
Regards,
Bernard.
next prev parent reply other threads:[~2018-06-29 14:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 8:08 [dpdk-dev] [PATCH v4 0/2] testpmd: simulating noisy host environment Maxime Coquelin
2018-06-23 8:08 ` [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour Maxime Coquelin
2018-06-26 11:09 ` Iremonger, Bernard
2018-06-29 13:38 ` Maxime Coquelin
2018-06-29 14:05 ` Iremonger, Bernard [this message]
2018-06-29 14:24 ` Maxime Coquelin
2018-06-29 14:28 ` Thomas Monjalon
2018-06-26 12:17 ` Shahaf Shuler
2018-06-26 13:38 ` Ferruh Yigit
2018-06-27 13:51 ` Shahaf Shuler
2018-06-27 14:09 ` Maxime Coquelin
2018-06-29 14:23 ` Maxime Coquelin
2018-06-27 11:43 ` Kevin Traynor
2018-06-27 14:12 ` Adrien Mazarguil
2018-06-23 8:08 ` [dpdk-dev] [PATCH v4 2/2] testpmd: update testpmd doc to include noisy forwarding mode Maxime Coquelin
2018-06-26 11:12 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260CBAC13@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=ailan@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jan.scheurich@ericsson.com \
--cc=jfreimann@redhat.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=vkaplans@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).