From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd
Date: Tue, 24 Jul 2018 09:08:57 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260CCEC76@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <20180718095443.31429-1-krzysztof.kanas@caviumnetworks.com>
Hi Krzysztof
> -----Original Message-----
> From: Krzysztof Kanas [mailto:krzysztof.kanas@caviumnetworks.com]
> Sent: Wednesday, July 18, 2018 10:55 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>;
> krzysztof.kanas@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Nithin Dabilpuram <nithin.dabilpuram@cavium.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH v2 2/2] app/testpmd: fix help string for tm commit cmd
>
> Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
> Cc: krzysztof.kanas@caviumnetworks.com
>
> Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> ---
> v2:
> * Fix the Fixes commit message line
> ---
> app/test-pmd/cmdline_tm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index
> 4f515241703a..09acc1b87293 100644
> --- a/app/test-pmd/cmdline_tm.c
> +++ b/app/test-pmd/cmdline_tm.c
> @@ -2172,7 +2172,7 @@ static void
> cmd_port_tm_hierarchy_commit_parsed(void *parsed_result,
> cmdline_parse_inst_t cmd_port_tm_hierarchy_commit = {
> .f = cmd_port_tm_hierarchy_commit_parsed,
> .data = NULL,
> - .help_str = "Set port tm node shaper profile",
> + .help_str = "Commit port tm hierarchy",
> .tokens = {
> (void *)&cmd_port_tm_hierarchy_commit_port,
> (void *)&cmd_port_tm_hierarchy_commit_tm,
> --
> 2.18.0
The check-git-log script is still showing an error:
./devtools/check-git-log.sh -1
Wrong 'Fixes' reference:
Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
It is better to send the complete patch set (2 patches) with each revision.
My ack can be carried forward on the first patch.
Regards,
Bernard.
next prev parent reply other threads:[~2018-07-24 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:50 [dpdk-dev] [PATCH 1/2] app/testpmd: fix use of uninitialized field Krzysztof Kanas
2018-07-10 6:51 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix help string for tm commit cmd Krzysztof Kanas
2018-07-18 8:51 ` Iremonger, Bernard
2018-07-18 9:54 ` [dpdk-dev] [PATCH v2 " Krzysztof Kanas
2018-07-24 9:08 ` Iremonger, Bernard [this message]
2018-07-25 12:41 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field Krzysztof Kanas
2018-07-25 12:41 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix help string for tm commit cmd Krzysztof Kanas
2018-07-25 13:23 ` Iremonger, Bernard
2018-07-25 13:22 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field Iremonger, Bernard
2018-07-26 17:36 ` Thomas Monjalon
2018-07-18 8:40 ` [dpdk-dev] [PATCH " Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260CCEC76@IRSMSX107.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=jingjing.wu@intel.com \
--cc=krzysztof.kanas@caviumnetworks.com \
--cc=nithin.dabilpuram@cavium.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).