From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding command in testpmd
Date: Wed, 25 Jul 2018 09:00:24 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260CCF2EE@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <ec489e49-7c7b-d790-99b0-4dfbc159d7ae@intel.com>
Hi Shreyansh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, July 23, 2018 9:49 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] doc: fix incorrect create bonding
> command in testpmd
>
> On 7/23/2018 12:27 PM, Shreyansh Jain wrote:
> > Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide")
> > Cc: john.mcnamara@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> > Note: Though the git blame suggest e76d7a768c as the last modification
> > for fixes, this actually existed when testpmd doc was added.
>
> You are right, I think fixes should be initial commit:
> Fixes: ac718398f477 ("doc: testpmd application user guide")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Could you send a v2 with the correct Fixes line.
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2018-07-25 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 11:27 Shreyansh Jain
2018-07-23 20:49 ` Ferruh Yigit
2018-07-25 9:00 ` Iremonger, Bernard [this message]
2018-07-25 11:31 ` [dpdk-stable] [PATCH v2] " Shreyansh Jain
2018-07-26 20:36 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260CCF2EE@IRSMSX107.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).