From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix metering and policing cli command
Date: Tue, 25 Sep 2018 14:16:29 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260CF45F6@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <54CBAA185211B4429112C315DA58FF6D33614488@IRSMSX103.ger.corp.intel.com>
Hi Jasvinder,
> -----Original Message-----
> From: Singh, Jasvinder
> Sent: Tuesday, September 25, 2018 12:02 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: RE: [PATCH] app/testpmd: fix metering and policing cli command
>
> > diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
> > > index f908fb3..32a4730 100644
> > > --- a/app/test-pmd/cmdline_mtr.c
> > > +++ b/app/test-pmd/cmdline_mtr.c
> > > @@ -414,9 +414,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_srtcm = {
> > > (void *)&cmd_add_port_meter_profile_srtcm_port,
> > > (void *)&cmd_add_port_meter_profile_srtcm_meter,
> > > (void *)&cmd_add_port_meter_profile_srtcm_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
> > > (void *)&cmd_add_port_meter_profile_srtcm_port_id,
> > > (void *)&cmd_add_port_meter_profile_srtcm_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_srtcm_srtcm_rfc2697,
> > > (void *)&cmd_add_port_meter_profile_srtcm_cir,
> > > (void *)&cmd_add_port_meter_profile_srtcm_cbs,
> > > (void *)&cmd_add_port_meter_profile_srtcm_ebs,
> > > @@ -521,9 +521,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_trtcm = {
> > > (void *)&cmd_add_port_meter_profile_trtcm_port,
> > > (void *)&cmd_add_port_meter_profile_trtcm_meter,
> > > (void *)&cmd_add_port_meter_profile_trtcm_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
> > > (void *)&cmd_add_port_meter_profile_trtcm_port_id,
> > > (void *)&cmd_add_port_meter_profile_trtcm_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_trtcm_trtcm_rfc2698,
> > > (void *)&cmd_add_port_meter_profile_trtcm_cir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_pir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_cbs,
> > > @@ -633,9 +633,9 @@ cmdline_parse_inst_t
> > > cmd_add_port_meter_profile_trtcm_rfc4115 = {
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_port,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_meter,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile,
> > > + (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_port_id,
> > > (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_profile_id,
> > > - (void
> > > *)&cmd_add_port_meter_profile_trtcm_rfc4115_trtcm_rfc4115,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_eir,
> > > (void *)&cmd_add_port_meter_profile_trtcm_rfc4115_cbs,
> > > --
> > > 2.9.3
> >
> > ./devtools/check-git-log.sh -1
> > Line too long:
> > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000
> > 3125000000 2500000 2500000
> >
> >
> > Also when I execute the command I get the following error:
> >
> > testpmd> add port meter profile trtcm_rfc2698 2 0 3125000000
> > testpmd> 3125000000
> > testpmd> 2500000 2500000
> > cause unspecified: Function not implemented (error 1)
> >
> > Is some more configuration needed to use this command?
> >
> Meter and policing support is only available in Softnic PMD, please trying
> using that when testing the CLI.
>
> Thanks,
> Jasvinder
The fix works with the Softnic PMD.
The commit message needs revision otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2018-09-25 14:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 9:02 Jasvinder Singh
2018-09-25 10:32 ` Iremonger, Bernard
2018-09-25 11:01 ` Singh, Jasvinder
2018-09-25 14:16 ` Iremonger, Bernard [this message]
2018-09-25 14:20 ` Singh, Jasvinder
2018-10-01 10:46 ` [dpdk-dev] [PATCH v2] " Jasvinder Singh
2018-10-08 16:08 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260CF45F6@IRSMSX107.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).