From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines
Date: Fri, 28 Jun 2019 13:45:13 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DBE4EB@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <AM4PR05MB3265D1F334F4FE9D8646FC57D2FD0@AM4PR05MB3265.eurprd05.prod.outlook.com>
Hi Bruce, Slava,
> -----Original Message-----
> From: Slava Ovsiienko [mailto:viacheslavo@mellanox.com]
> Sent: Thursday, June 27, 2019 5:49 AM
> To: Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
> Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst
> routines
>
> OK, what do you think about this:
>
> #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES
> if (record_cycle & RECORD_TX_CORE_CYCLES) {
> .. do measurement stuff ..
> }
> #endif
>
> + add some new command to config in runtime: "set record_cycle 3"
>
> We keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES, do not introduce
> new build-time configs and get some new runtime configuring.
>
> WBR,
> Slava
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Wednesday, June 26, 2019 16:21
> > To: Slava Ovsiienko <viacheslavo@mellanox.com>
> > Cc: dev@dpdk.org; bernard.iremonger@intel.com; ferruh.yigit@intel.com
> > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx
> > burst routines
> >
> > On Wed, Jun 26, 2019 at 01:19:24PM +0000, Slava Ovsiienko wrote:
> > > Hi, Bruce
> > >
> > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef ?
> > >
> > > No, I did not try runtime control settings.
> > > Instead I compared performance with all RECORD_CORE_XX_CYCLES
> > options
> > > enabled/disabled builds and have seen the ~1-2% performance
> > > difference
> > on my setups (mainly fwd txonly with retry).
> > > So, ticks measuring is not free.
> > >
> > > With best regards,
> > > Slava
> > >
> > Yes, I realise that measuring ticks is going to have a performance impact.
> > However, what I was referring to was exactly the former - using an "if"
> > rather than an "ifdef". I would hope with ticks disable using this
> > option shows no perf impact, and we can reduce the use of build-time
> configs.
> >
> > /Bruce
Given that RTE_TEST_PMD_RECORD_CORE_CYCLES is already in the config file.
I think it is better to be consistent and add the new RECORD macros there.
Would it be reasonable to have runtime settings available as well?
Regards,
Bernard
next prev parent reply other threads:[~2019-06-28 13:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:48 Viacheslav Ovsiienko
2019-06-26 12:57 ` Bruce Richardson
2019-06-26 13:19 ` Slava Ovsiienko
2019-06-26 13:21 ` Bruce Richardson
2019-06-27 4:48 ` Slava Ovsiienko
2019-06-28 13:45 ` Iremonger, Bernard [this message]
2019-06-28 14:20 ` Bruce Richardson
2019-07-01 4:57 ` Slava Ovsiienko
2019-07-01 8:15 ` Bruce Richardson
2019-09-30 12:32 ` Yigit, Ferruh
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data on burst size Viacheslav Ovsiienko
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command Viacheslav Ovsiienko
2020-04-02 11:15 ` Thomas Monjalon
2020-04-09 11:56 ` Ferruh Yigit
2020-04-13 7:56 ` Slava Ovsiienko
2020-04-13 12:23 ` Thomas Monjalon
2020-04-14 9:07 ` Ferruh Yigit
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling Viacheslav Ovsiienko
2020-04-02 11:20 ` Thomas Monjalon
2020-04-02 11:23 ` Slava Ovsiienko
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size Viacheslav Ovsiienko
2020-03-20 6:13 ` Jerin Jacob
2020-04-09 11:46 ` Ferruh Yigit
2020-04-09 12:49 ` Jerin Jacob
2020-03-20 16:03 ` Andrzej Ostruszka
2020-04-02 11:21 ` Thomas Monjalon
2020-04-09 12:03 ` Ferruh Yigit
2020-04-09 12:09 ` Thomas Monjalon
2020-04-02 11:13 ` [dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260DBE4EB@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).