From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Mcloughlin, Aideen" <aideen.mcloughlin@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix doubling of 'total TX dropped'
Date: Fri, 12 Jul 2019 13:33:46 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260DCF8E5@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20190712083221.4987-1-aideen.mcloughlin@intel.com>
Hi Aideen,
> -----Original Message-----
> From: Mcloughlin, Aideen
> Sent: Friday, July 12, 2019 9:32 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Mcloughlin, Aideen <aideen.mcloughlin@intel.com>;
> david.marchand@redhat.com; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix doubling of 'total TX dropped'
>
> The 'Accumulated forward statistics for all ports' incorrectly displayed double
> the actual value for 'total_tx_dropped'. This was because 2 lines in the same
> function both incremented total_tx_dropped every time a packet was
> dropped. I removed one of these lines to fix this issue.
>
> Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on
> demand")
> Cc: david.marchand@redhat.com
> Cc: stable@dpdk.org
>
> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
./devtools/check-git-log.sh -1
Wrong headline lowercase:
app/testpmd: fix doubling of 'total TX dropped'
Otherwise
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
next prev parent reply other threads:[~2019-07-12 13:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 8:32 A.McLoughlin
2019-07-12 13:33 ` Iremonger, Bernard [this message]
2019-07-15 14:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-07-16 12:23 ` Andrew Rybchenko
2019-07-16 14:23 ` Ferruh Yigit
2019-07-16 14:28 ` Bruce Richardson
2019-07-16 15:00 ` Andrew Rybchenko
2019-07-16 15:29 ` Ferruh Yigit
2019-07-23 11:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C260DCF8E5@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=aideen.mcloughlin@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).