From: "Wang, Zhihong" <zhihong.wang@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start
Date: Thu, 26 May 2016 02:56:39 +0000 [thread overview]
Message-ID: <8F6C2BD409508844A0EFC19955BE09411074375A@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <2604231.jECmEcnI7g@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, May 25, 2016 5:45 PM
> To: Wang, Zhihong <zhihong.wang@intel.com>
> Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: Re: [PATCH 5/6] testpmd: show topology at forwarding start
>
> 2016-05-05 18:47, Zhihong Wang:
> > This patch show topology at forwarding start.
> >
> > "show config fwd" also does this, but showing it directly can reduce the
> > possibility of misconfiguration.
> [...]
> > - fwd_config_setup();
> > + fwd_config_display();
> > rxtx_config_display();
>
> Having _display() calling _setup() is really strange.
> Maybe it is worth to be fixed in this patch.
It looks strange to me too. Will look for a fix.
next prev parent reply other threads:[~2016-05-26 2:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 22:46 [dpdk-dev] [PATCH 0/6] vhost/virtio performance loopback utility Zhihong Wang
2016-05-05 22:46 ` [dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding Zhihong Wang
2016-05-25 9:32 ` Thomas Monjalon
2016-05-26 2:40 ` Wang, Zhihong
2016-05-26 6:27 ` Thomas Monjalon
2016-05-26 9:24 ` Wang, Zhihong
2016-05-05 22:46 ` [dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number Zhihong Wang
2016-05-25 9:35 ` Thomas Monjalon
2016-05-26 2:53 ` Wang, Zhihong
2016-05-26 6:31 ` Thomas Monjalon
2016-05-26 9:31 ` Wang, Zhihong
2016-05-05 22:46 ` [dpdk-dev] [PATCH 3/6] testpmd: show throughput in port stats Zhihong Wang
2016-05-05 22:46 ` [dpdk-dev] [PATCH 4/6] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-05-25 9:42 ` Thomas Monjalon
2016-05-26 2:55 ` Wang, Zhihong
2016-06-03 9:22 ` Wang, Zhihong
2016-05-05 22:47 ` [dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start Zhihong Wang
2016-05-25 9:45 ` Thomas Monjalon
2016-05-26 2:56 ` Wang, Zhihong [this message]
2016-05-05 22:47 ` [dpdk-dev] [PATCH 6/6] testpmd: update documentation Zhihong Wang
2016-05-25 9:48 ` Thomas Monjalon
2016-05-26 2:54 ` Wang, Zhihong
2016-05-20 8:54 ` [dpdk-dev] [PATCH 0/6] vhost/virtio performance loopback utility Wang, Zhihong
2016-05-25 9:27 ` Thomas Monjalon
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 0/5] " Zhihong Wang
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 1/5] testpmd: add retry option Zhihong Wang
2016-06-07 9:28 ` De Lara Guarch, Pablo
2016-06-08 1:29 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 2/5] testpmd: configurable tx_first burst number Zhihong Wang
2016-06-07 9:43 ` De Lara Guarch, Pablo
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 3/5] testpmd: show throughput in port stats Zhihong Wang
2016-06-07 10:02 ` De Lara Guarch, Pablo
2016-06-08 1:31 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 4/5] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-06-07 10:29 ` De Lara Guarch, Pablo
2016-06-08 1:28 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start Zhihong Wang
2016-06-07 10:56 ` De Lara Guarch, Pablo
2016-06-14 15:13 ` De Lara Guarch, Pablo
2016-06-15 7:05 ` Wang, Zhihong
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 0/5] vhost/virtio performance loopback utility Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 1/5] testpmd: add retry option Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 2/5] testpmd: configurable tx_first burst number Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 3/5] testpmd: show throughput in port stats Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 4/5] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-06-27 14:23 ` Nélio Laranjeiro
2016-06-27 22:36 ` De Lara Guarch, Pablo
2016-06-28 8:34 ` Nélio Laranjeiro
2016-06-28 11:10 ` Wang, Zhihong
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 5/5] testpmd: show topology at forwarding start Zhihong Wang
2016-06-16 11:09 ` De Lara Guarch, Pablo
2016-06-16 13:33 ` Thomas Monjalon
2016-06-15 10:04 ` [dpdk-dev] [PATCH v3 0/5] vhost/virtio performance loopback utility De Lara Guarch, Pablo
2016-06-16 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F6C2BD409508844A0EFC19955BE09411074375A@SHSMSX103.ccr.corp.intel.com \
--to=zhihong.wang@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).