DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Zhihong" <zhihong.wang@intel.com>
To: Ravi Kerur <rkerur@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions
Date: Thu, 26 May 2016 09:05:08 +0000	[thread overview]
Message-ID: <8F6C2BD409508844A0EFC19955BE09411074394E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1457391644-29645-2-git-send-email-rkerur@gmail.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur
> Sent: Tuesday, March 8, 2016 7:01 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions
> 
> v1:
>         This patch adds test cases for rte_memcmp functions.
>         New rte_memcmp functions can be tested via 'make test'
>         and 'testpmd' utility.
> 
>         Compiled and tested on Ubuntu 14.04(non-NUMA) and
>         15.10(NUMA) systems.
[...]

> +/************************************************************
> *******************
> + * Memcmp function performance test configuration section. Each performance
> test
> + * will be performed MEMCMP_ITERATIONS times.
> + *
> + * The five arrays below control what tests are performed. Every combination
> + * from the array entries is tested.
> + */
> +#define MEMCMP_ITERATIONS (500 * 500 * 500)


Maybe less iteration will make the test faster without compromise precison?


> +
> +static size_t memcmp_sizes[] = {
> +	2, 5, 8, 9, 15, 16, 17, 31, 32, 33, 63, 64, 65, 127, 128,
> +	129, 191, 192, 193, 255, 256, 257, 319, 320, 321, 383, 384,
> +	385, 447, 448, 449, 511, 512, 513, 767, 768, 769, 1023, 1024,
> +	1025, 1522, 1536, 1600, 2048, 2560, 3072, 3584, 4096, 4608,
> +	5632, 6144, 6656, 7168, 7680, 8192, 16834
> +};
> +
[...]
> +/*
> + * Do all performance tests.
> + */
> +static int
> +test_memcmp_perf(void)
> +{
> +	if (run_all_memcmp_eq_perf_tests() != 0)
> +		return -1;
> +
> +	if (run_all_memcmp_gt_perf_tests() != 0)
> +		return -1;
> +
> +	if (run_all_memcmp_lt_perf_tests() != 0)
> +		return -1;
> +


Perhaps unaligned test cases are needed here.
How do you think?


> +
> +	return 0;
> +}
> +
> +static struct test_command memcmp_perf_cmd = {
> +	.command = "memcmp_perf_autotest",
> +	.callback = test_memcmp_perf,
> +};
> +REGISTER_TEST_COMMAND(memcmp_perf_cmd);
> --
> 1.9.1

  reply	other threads:[~2016-05-26  9:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07 22:59 [dpdk-dev] [PATCH v1 0/2] " Ravi Kerur
2016-03-07 23:00 ` [dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and SSE intrinsics Ravi Kerur
2016-03-07 23:00   ` [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions Ravi Kerur
2016-05-26  9:05     ` Wang, Zhihong [this message]
2016-06-06 18:31       ` Ravi Kerur
2016-06-07 11:09         ` Wang, Zhihong
2017-01-02 20:41           ` Thomas Monjalon
2017-01-09  5:29             ` Wang, Zhihong
2017-01-09 11:08               ` Thomas Monjalon
2017-01-11  1:28                 ` Wang, Zhihong
2016-05-25  8:56   ` [dpdk-dev] [PATCH v1 1/2] rte_memcmp functions using Intel AVX and SSE intrinsics Thomas Monjalon
2016-05-26  8:57   ` Wang, Zhihong
2018-12-20 23:30     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8F6C2BD409508844A0EFC19955BE09411074394E@SHSMSX103.ccr.corp.intel.com \
    --to=zhihong.wang@intel.com \
    --cc=dev@dpdk.org \
    --cc=rkerur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).