From: "Wang, Zhihong" <zhihong.wang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling
Date: Mon, 23 Nov 2015 01:31:59 +0000 [thread overview]
Message-ID: <8F6C2BD409508844A0EFC19955BE094183533E@SHSMSX152.ccr.corp.intel.com> (raw)
In-Reply-To: <20151120083258.033e0498@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, November 21, 2015 12:33 AM
> To: Wang, Zhihong <zhihong.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary
> hugepage zero-filling
>
> On Thu, 19 Nov 2015 20:53:48 -0500
> Zhihong Wang <zhihong.wang@intel.com> wrote:
>
> > The kernel fills new allocated (huge) pages with zeros.
> > DPDK just has to touch the pages to trigger the allocation.
> >
> > Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
>
> The code is correct, and optimized.
> Don't you need to update the commit message since you no longer have to touch
> the pages.
Thanks for pointing this out!
prev parent reply other threads:[~2015-11-23 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 1:53 [dpdk-dev] [PATCH RFC v2 0/2] Reduce DPDK initialization time Zhihong Wang
2015-11-20 1:53 ` [dpdk-dev] [PATCH RFC v2 1/2] lib/librte_eal: Reduce timer " Zhihong Wang
2015-11-20 16:31 ` Stephen Hemminger
2015-11-23 1:29 ` Wang, Zhihong
2015-11-20 1:53 ` [dpdk-dev] [PATCH RFC v2 2/2] lib/librte_eal: Remove unnecessary hugepage zero-filling Zhihong Wang
2015-11-20 16:32 ` Stephen Hemminger
2015-11-23 1:31 ` Wang, Zhihong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F6C2BD409508844A0EFC19955BE094183533E@SHSMSX152.ccr.corp.intel.com \
--to=zhihong.wang@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).