From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [PATCH v2 7/9] vhost: remove multi-line logs
Date: Wed, 26 Jan 2022 10:30:11 +0100 [thread overview]
Message-ID: <8a8e0453-2b7a-e780-356c-c5d68c1c65d3@redhat.com> (raw)
In-Reply-To: <SN6PR11MB3504B5FF1D1E3FC304D8E2D09C209@SN6PR11MB3504.namprd11.prod.outlook.com>
Hi Chenbo,
On 1/26/22 04:27, Xia, Chenbo wrote:
> Hi Maxime,
>
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Tuesday, January 25, 2022 7:25 PM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
>> david.marchand@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH v2 7/9] vhost: remove multi-line logs
>>
>> This patch replaces multi-lines logs in multiple single-
>> line logs in order to ease logs filtering based on their
>> socket path.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/vhost/socket.c | 10 ++--
>> lib/vhost/vhost.c | 8 ++--
>> lib/vhost/vhost_user.c | 106 +++++++++++++++++++----------------------
>> 3 files changed, 60 insertions(+), 64 deletions(-)
>>
...
>> @@ -1122,8 +1121,7 @@ vhost_user_postcopy_region_register(struct virtio_net
>> *dev,
>>
>> if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER,
>> ®_struct)) {
>> - VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region "
>> - "%" PRIx64 " - %" PRIx64 " (ufd = %d) %s\n",
>> + VHOST_LOG_CONFIG(ERR, "(%s) failed to register ufd for region %"
>> PRIx64 " - %" PRIx64 " (ufd = %d) %s\n",
>
> This line is > 100 chars, and I think the original one is fine for log filtering
> or using log to search code.
> What do you think?
Makes sense, I will revert this change in v3.
Thanks,
Maxime
next prev parent reply other threads:[~2022-01-26 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 11:24 [PATCH v2 0/9] vhost: improve logging Maxime Coquelin
2022-01-25 11:24 ` [PATCH v2 1/9] vhost: improve IOTLB logs Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 2/9] vhost: improve vDPA registration failure log Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 3/9] vhost: improve Vhost layer logs Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 4/9] vhost: improve Vhost-user " Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 5/9] vhost: improve socket " Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 6/9] vhost: improve Virtio-net " Maxime Coquelin
2022-01-26 3:26 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 7/9] vhost: remove multi-line logs Maxime Coquelin
2022-01-26 3:27 ` Xia, Chenbo
2022-01-26 9:30 ` Maxime Coquelin [this message]
2022-01-25 11:24 ` [PATCH v2 8/9] vhost: differentiate IOTLB logs Maxime Coquelin
2022-01-26 3:27 ` Xia, Chenbo
2022-01-25 11:24 ` [PATCH v2 9/9] vhost: use proper logging type for data path Maxime Coquelin
2022-01-26 3:27 ` Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a8e0453-2b7a-e780-356c-c5d68c1c65d3@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).