From: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 2/2] vhost: refactor to follow new naming convention
Date: Thu, 9 Mar 2023 13:51:49 +0900 [thread overview]
Message-ID: <8aacfc34-667d-57d5-844f-fc6f0b7268f2@yahoo-corp.jp> (raw)
In-Reply-To: <SN6PR11MB350406B6FF1788964CC2522E9CB59@SN6PR11MB3504.namprd11.prod.outlook.com>
On 2023/03/09 12:03, Xia, Chenbo wrote:
> Hi Nobuhiro,
>
> Thanks for the work, check comments inline.
>
>> -----Original Message-----
>> From: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
>> Sent: Thursday, March 9, 2023 10:07 AM
>> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
>> Cc: dev@dpdk.org; Nobuhiro MIKI <nmiki@yahoo-corp.jp>
>> Subject: [PATCH 2/2] vhost: refactor to follow new naming convention
>>
>> Simply replace '_slave_' with '_backend_'.
>>
>> Signed-off-by: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
>> ---
>> drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +-
>> lib/vhost/rte_vhost.h | 2 +-
>> lib/vhost/version.map | 2 +-
>> lib/vhost/vhost.c | 4 +--
>> lib/vhost/vhost.h | 4 +--
>> lib/vhost/vhost_user.c | 62 +++++++++++++++++------------------
>> lib/vhost/vhost_user.h | 6 ++--
>> 7 files changed, 41 insertions(+), 41 deletions(-)
>>
>> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
>> index fe4d278c5380..e4133568c1aa 100644
>> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
>> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
>> @@ -605,7 +605,7 @@ virtio_interrupt_handler(struct ifcvf_internal
>> *internal)
>
> ...
>
>>
>> typedef struct VhostUserMemoryRegion {
>> uint64_t guest_phys_addr;
>> @@ -137,7 +137,7 @@ struct vhost_user_config {
>> typedef struct VhostUserMsg {
>> union {
>> uint32_t master; /* a VhostUserRequest value */
>> - uint32_t slave; /* a VhostUserSlaveRequest value*/
>> + uint32_t backend; /* a VhostUserBackendRequest value*/
>
> I think we should rename the master to front-end too (as QEMU spec says)
>
> If you can also replace all the 'masters' with front-end too, we will appreciate
> that much..
>
> BTW, I guess this is your first patch, you need to update .mailmap file with your
> name and email address.
Hi Chenbo,
Thanks for your review.
I will fix them in v2.
Best Regards,
Nobuhiro MIKI
next prev parent reply other threads:[~2023-03-09 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 2:07 [PATCH 0/2] vhost: fix names " Nobuhiro MIKI
2023-03-09 2:07 ` [PATCH 1/2] vhost: fix constants to follow new naming convension Nobuhiro MIKI
2023-03-09 3:06 ` Xia, Chenbo
2023-03-09 2:07 ` [PATCH 2/2] vhost: refactor to follow new naming convention Nobuhiro MIKI
2023-03-09 3:03 ` Xia, Chenbo
2023-03-09 4:51 ` Nobuhiro MIKI [this message]
2023-03-09 2:40 ` [PATCH 0/2] vhost: fix names " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aacfc34-667d-57d5-844f-fc6f0b7268f2@yahoo-corp.jp \
--to=nmiki@yahoo-corp.jp \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).